Skip to content

Support for LLVM 10 #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kennykerr merged 1 commit into from
Jun 25, 2020
Merged

Support for LLVM 10 #669

kennykerr merged 1 commit into from
Jun 25, 2020

Conversation

@kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Jun 25, 2020

Fixes #659

Note that full Clang support is currently hampered by the fact that Clang doesn't like the current VC libraries and fails to compile them. Other than that, this update fixes two minor issues that Clang didn't like about recent changes to C++/WinRT.

         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\xutility(63,5): error : non-void constexpr function '_Bit_cast' should return a value [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1196,15): error : no matching function for call to '_Bit_cast' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1291,9): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1353,21): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1269,15): error : no matching function for call to '_Bit_cast' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1512,13): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1629,12): error : no matching function for call to '_Assemble_floating_point_value' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1392,16): error : no matching function for call to '_Assemble_floating_point_value' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1414,16): error : no matching function for call to '_Assemble_floating_point_value' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1442,12): error : no matching function for call to '_Assemble_floating_point_value' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1939,5): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(2003,14): error : no matching function for call to '_Bit_cast' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\xutility(63,5): error : non-void constexpr function '_Bit_cast' should return a value [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1196,15): error : no matching function for call to '_Bit_cast' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1291,9): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1353,21): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1269,15): error : no matching function for call to '_Bit_cast' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1512,13): error : no matching function for call to '_Assemble_floating_point_infinity' [C:\git\cppwinrt\scratch\scratch.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\VC\Tools\MSVC\14.27.29009\include\charconv(1629,12): error : no matching function for call to '_Assemble_floating_point_value' [C:\git\cppwinrt\scratch\scratch.vcxproj]

@kennykerr kennykerr requested a review from oldnewthing June 25, 2020 15:41
kennykerr
kennykerr commented Jun 25, 2020
View reviewed changes
strings/base_coroutine_foundation.h
private:
std::experimental::coroutine_handle<> m_handle;
resume_apartment_context m_context;
std::experimental::coroutine_handle<> m_handle;
Copy link
Collaborator Author

@kennykerr kennykerr Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor and field order were inconsistent, leading to a Clang warning.

kennykerr
kennykerr commented Jun 25, 2020
View reviewed changes
@kennykerr
Copy link
Collaborator Author

kennykerr commented Jun 25, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 25, 2020

No pipelines are associated with this pull request.

@kennykerr kennykerr merged commit 4fa0e40 into master Jun 25, 2020
@kennykerr kennykerr deleted the kennykerr-clang10 branch June 25, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oldnewthing oldnewthing oldnewthing approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Structured bindings and captures issue with Clang

3 participants

@kennykerr @oldnewthing