Skip to content

Support for LLVM 10 #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 1 commit into from
Jun 25, 2020
Merged

Support for LLVM 10 #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions strings/base_coroutine_foundation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ namespace winrt::impl
}

private:
std::experimental::coroutine_handle<> m_handle;
resume_apartment_context m_context;
std::experimental::coroutine_handle<> m_handle;
Copy link
Collaborator Author

@kennykerr kennykerr Jun 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor and field order were inconsistent, leading to a Clang warning.


void Complete()
{
Expand Down Expand Up @@ -743,7 +743,7 @@ WINRT_EXPORT namespace winrt

auto [delegate, shared] = impl::make_delegate_with_shared_state<impl::async_completed_handler_t<T>>(shared_type{});

auto completed = [&](T const& async)
auto completed = [delegate = std::move(delegate)](T const& async)
{
async.Completed(delegate);
};
Expand Down