Skip to content

Clear axios timeout after request is done#383

Closed
osortega wants to merge 1 commit intomicrosoft:mainfrom
osortega:osortega/clear-axios-timeout
Closed

Clear axios timeout after request is done#383
osortega wants to merge 1 commit intomicrosoft:mainfrom
osortega:osortega/clear-axios-timeout

Conversation

@osortega
Copy link
Copy Markdown

Changes proposed:

Clearing the timeout that handles the abort signal for the axios request.

This way we make sure that future requests do not get aborted by mistake.

Other Tasks:

  • If you updated the Go SDK did you update the PackageVersion in tunnels.go
  • If you updated the TS SDK did you update the dependencies in package.json for connections and management to require a dependency that is > the current published version(Found using npm view @microsoft/dev-tunnels-contracts). This will fix issues where yarn will pull the old version of packages and will cause mismatched dependencies. See example PR

@jramsay jramsay closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants