Skip to content

Clear axios timeout after request is done #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
osortega wants to merge 1 commit into from
Closed

Clear axios timeout after request is done #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ts/src/management/tunnelManagementHttpClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,13 +1090,14 @@ export class TunnelManagementHttpClient implements TunnelManagementClient {

let disposable: Disposable | undefined;
const abortController = new AbortController();
let timeOutId: number | undefined;
const newAbortSignal = () => {
if (cancellation?.isCancellationRequested) {
abortController.abort();
} else if (cancellation) {
disposable = cancellation.onCancellationRequested(() => abortController.abort());
} else {
setTimeout(() => abortController.abort(), defaultRequestTimeoutMS);
timeOutId = setTimeout(() => abortController.abort(), defaultRequestTimeoutMS);
}
return abortController.signal;
}
Expand Down Expand Up @@ -1136,6 +1137,8 @@ export class TunnelManagementHttpClient implements TunnelManagementClient {

throw requestError;
} finally {
// clear abort timeout
clearTimeout(timeOutId);
disposable?.dispose();
}
}
Expand Down