Strip unneeded symbols from minsizerel binaries #41
Conversation
| make | ||
| make install | ||
|
|
||
| echo "Finished bootstrapping" |
There was a problem hiding this comment.
Something I've been thinking about based on other boostrap scripts is to have all of these consolidated into a single bootstrap script, where platform is automatically detected. That way we can deduplicate some of the script commands to install things like python, make, etc.
I think based on what I've seen, it's also fairly standard to have the bootstrap scripts do a build of whatever the repo is before completing to verify things work correctly.
Totally unrelated to this PR though, I'll open a new task for the above:
https://microsoft.visualstudio.com/OS/_workitems/edit/32499146/?workitem=33759607 #Closed
There was a problem hiding this comment.
Yes, de-duplicate and a test build sounds great.
|
I use vscode to debug via attach to process, I imagine stripping symbols from the exe may require vscode to be provided the .pdb path now. No worries on this - just thinking out loud. #Closed Refers to: common/cmake/do-build-helpers.cmake:138 in 284d3fa. [](commit_id = 284d3fa, deletion_comment = False) |
| endif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux") | ||
|
|
||
| # From https://github.com/dotnet/coreclr/pull/3872/files | ||
| # For minsizerel build, split unneeded symbols from target binary file and into a separate .dbg file. |
There was a problem hiding this comment.
Don't know. That's how gcc works. I should mention that it is stripping more than just debug symbols. I didn't dig to find exactly what is stripped (will do that when there's time).
* Use CredScanSuppressions.json instead of inline comments (#15) * Add support for additional build types (#28) Add support for additional build types * Fix dockerfile for Deb10 (#29) * Support Ubuntu 20.04 arm64 builds and fix boost log linker issue (#31) * Update readme with section detailing install (#33) * Return specific errors from creating and accessing the destination file path (#35) * Provide better errors for dest file path. Use POSIX APIs. * Fix tests to account for this. * deliveryoptimization_set_iot_connection_string returns specific error codes * Fix WIL link * Cleanup download in all cases, avoid overwriting existing files (#36) * SDK: Ensure download is cleaned up in all cases * Agent: Avoid overwriting existing destination file * Agent: Fix file path logging in cancel event * Check binary size growth in azure pipelines (#38) * Check runs only for minsizerel flavor. * Baseline number obtained from local dev build. * Binary size increase of 5% or more results in build failure. Think carefully before increasing the baseline at any time. * SDK: Prepare to remove cpprestsdk dependency (#39) * CPortFinder provides port only, address constructed by CHttpClient. * Remove unused CHttpClient SendRequest method that supported request body. * Simplify SendRequest. Use boost ptree. * SDK: Remove cpprestsdk, use custom code with boost.asio (#40) * Custom, minimal, http parser implementation, on top of Boost.Asio. * Fix minsizerel build warning in class download. * Re-enable some tests. * Strip unneeded symbols from minsizerel binaries (#41) * Bootstrap only required boost libs * Strip unneeded symbols from minsizerel binaries. * Fix deb10 build. boost::asio::io_service backcompat. * Update limits for binary size check * Agent: Move log location to /var/log (#43) * This removes usage of /var/cache * Group write permissions needed only for the config path * Make strip_symbols optional (#44) * Some build environments do not have objcopy installed (like Yocto Zeus) * Agent: Update MCC fallback logic (#45) * Custom fallback logic: oscillate between MCC and original host when possible. * Ban MCC on fatal errors only. * 4xx errors are fatal for MCC also. * ConfigManager handling -1 fallback config. * Fix mcc manager tests not appending json files properly. * Agent: Reset retry delay on fallback from MCC * SDK: Add test to exercise new MCC fallback logic * Increment versions for release v0.7.0 (#50) agent, sdk: 0.5.0 plugin-apt: 0.3.0 * Fix github_release.yml (#52) * echo in Release Information task needs the text wrapped in quotes. * Use minsizerel for building all components. * Migrate azdo resources to 1ES managed pool (#51) * use ninja (#53) * Agent: Replace boost.log usage with custom logger (#54) * Agent: Remove boost.log requirement from test (#55) * SDK: Remove inline spaces in favor of nested namespaces (#57) Co-authored-by: shishirb-MSFT <50385517+shishirb-MSFT@users.noreply.github.com> Co-authored-by: Shishir Bhat <shishirb@microsoft.com>
No description provided.