Agent: Move log location to /var/log #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimson-msft
reviewed
Jun 16, 2021
| configure_dir "$config_path" | ||
| configure_dir "$persistence_path" | ||
| # group needs write permission to config path (SDK writing configs) | ||
| chmod g+w $config_path |
Contributor
There was a problem hiding this comment.
possible to still have this within configure_dir()? where configure_dir() accepts a bool param to check whether it should set group write permissions? #Closed
Collaborator
Author
There was a problem hiding this comment.
Not worth it I felt.
jimson-msft
reviewed
Jun 16, 2021
shishirb-MSFT
commented
Jun 17, 2021
sdk-cpp/tests/download_tests.cpp
Outdated
| }); | ||
| TestHelpers::CreateRestPortFiles(5); | ||
| ASSERT_GE(TestHelpers::CountRestPortFiles(), 5u); | ||
| std::this_thread::sleep_for(std::chrono::seconds(2)); |
Collaborator
Author
jimson-msft
approved these changes
Jun 17, 2021
jimson-msft
added a commit
that referenced
this pull request
Aug 25, 2021
* Use CredScanSuppressions.json instead of inline comments (#15) * Add support for additional build types (#28) Add support for additional build types * Fix dockerfile for Deb10 (#29) * Support Ubuntu 20.04 arm64 builds and fix boost log linker issue (#31) * Update readme with section detailing install (#33) * Return specific errors from creating and accessing the destination file path (#35) * Provide better errors for dest file path. Use POSIX APIs. * Fix tests to account for this. * deliveryoptimization_set_iot_connection_string returns specific error codes * Fix WIL link * Cleanup download in all cases, avoid overwriting existing files (#36) * SDK: Ensure download is cleaned up in all cases * Agent: Avoid overwriting existing destination file * Agent: Fix file path logging in cancel event * Check binary size growth in azure pipelines (#38) * Check runs only for minsizerel flavor. * Baseline number obtained from local dev build. * Binary size increase of 5% or more results in build failure. Think carefully before increasing the baseline at any time. * SDK: Prepare to remove cpprestsdk dependency (#39) * CPortFinder provides port only, address constructed by CHttpClient. * Remove unused CHttpClient SendRequest method that supported request body. * Simplify SendRequest. Use boost ptree. * SDK: Remove cpprestsdk, use custom code with boost.asio (#40) * Custom, minimal, http parser implementation, on top of Boost.Asio. * Fix minsizerel build warning in class download. * Re-enable some tests. * Strip unneeded symbols from minsizerel binaries (#41) * Bootstrap only required boost libs * Strip unneeded symbols from minsizerel binaries. * Fix deb10 build. boost::asio::io_service backcompat. * Update limits for binary size check * Agent: Move log location to /var/log (#43) * This removes usage of /var/cache * Group write permissions needed only for the config path * Make strip_symbols optional (#44) * Some build environments do not have objcopy installed (like Yocto Zeus) * Agent: Update MCC fallback logic (#45) * Custom fallback logic: oscillate between MCC and original host when possible. * Ban MCC on fatal errors only. * 4xx errors are fatal for MCC also. * ConfigManager handling -1 fallback config. * Fix mcc manager tests not appending json files properly. * Agent: Reset retry delay on fallback from MCC * SDK: Add test to exercise new MCC fallback logic * Increment versions for release v0.7.0 (#50) agent, sdk: 0.5.0 plugin-apt: 0.3.0 * Fix github_release.yml (#52) * echo in Release Information task needs the text wrapped in quotes. * Use minsizerel for building all components. * Migrate azdo resources to 1ES managed pool (#51) * use ninja (#53) * Agent: Replace boost.log usage with custom logger (#54) * Agent: Remove boost.log requirement from test (#55) * SDK: Remove inline spaces in favor of nested namespaces (#57) Co-authored-by: shishirb-MSFT <50385517+shishirb-MSFT@users.noreply.github.com> Co-authored-by: Shishir Bhat <shishirb@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.