Cleanup comments #93
Cleanup comments #93
Conversation
Co-authored-by: Jimmy Song <55897143+jimson-msft@users.noreply.github.com> Cherry-picked from #89
| ArtifactName: 'deliveryoptimization-agent' | ||
| publishLocation: 'Container' | ||
|
|
||
| # TODO(jimson) Azure artifacts are no longer free to publish to, this task will fail as a result, bug to resolve issue here: |
There was a problem hiding this comment.
Im removing these stubs, they're in the commit history if we need to bring them back. Also since weturned on subscription billing for our ADO project, we can theoretically use this feature now.
Nick/Oscar's team own testing going forward, so if they want to use ADO package feeds to retrieve artifacts, we can bring this back. #Closed
| # publishPackageMetadata: false | ||
| # vstsFeedPackagePublish: 'deliveryoptimization-plugin-apt' | ||
| # versionOption: 'custom' | ||
| # versionPublish: '$(test.package.version)' |
There was a problem hiding this comment.
Nope - they do not. Good point though
| DODownloadProperty_IntegrityCheckInfo, | ||
| DODownloadProperty_IntegrityCheckMandatory, | ||
| DODownloadProperty_TotalSizeBytes, | ||
| DODownloadProperty_DisallowOnCellular, // TODO: Document this (Win11) |
There was a problem hiding this comment.
I'll add a comment for the first two, I'm going to delete the last two for now. By the time these become available the windows sdk will have shipped with these two.
There was a problem hiding this comment.
Also because the enum in do_download_property would need to include these two, and people using this wouldn't have an easy way to test those two properties since they'd have to use a prerelease build (for now)
2 participants
No description provided.