Skip to content

Support Ubuntu 20.04 on amd64 and arm64 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimson-msft merged 17 commits into from
Oct 21, 2021
Merged

Support Ubuntu 20.04 on amd64 and arm64 #96

jimson-msft merged 17 commits into from
Oct 21, 2021

Conversation

@jimson-msft
Copy link
Contributor

@jimson-msft jimson-msft commented Oct 20, 2021

No description provided.

shishirb-MSFT and others added 12 commits October 6, 2021 22:09
@jimson-msft jimson-msft requested a review from a team as a code owner October 20, 2021 23:33
shishirb-MSFT
shishirb-MSFT reviewed Oct 21, 2021
View reviewed changes
build/docker/ubuntu2004/amd64/bootstrap.sh Outdated
@@ -0,0 +1,238 @@
#! /bin/bash
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Oct 21, 2021 •
edited by jimson-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this script right? The one in build/scripts/bootstrap.sh works for ubuntu2004. #Resolved

Copy link
Contributor Author

@jimson-msft jimson-msft Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yea, got brought over whe building the image

shishirb-MSFT
shishirb-MSFT reviewed Oct 21, 2021
View reviewed changes
build/scripts/bootstrap.sh Outdated
then


echo "[INFO] Installing build dependencies"
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Oct 21, 2021 •
edited by jimson-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo "[INFO] Installing build dependencies"

Duplicate log line. See line 75. #Resolved

@shishirb-MSFT
Copy link
Collaborator

shishirb-MSFT commented Oct 21, 2021 •
edited by jimson-msft
Loading 

if [[ $"PLATFORM" != "unknown" ]]

$ should go after the opening quote "

In reply to: 948212963

Refers to: build/scripts/bootstrap.sh:67 in d7a831e. [](commit_id = d7a831e, deletion_comment = False)

shishirb-MSFT
shishirb-MSFT reviewed Oct 21, 2021
View reviewed changes
build/docker/ubuntu2004/amd64/Dockerfile Outdated
@@ -0,0 +1,36 @@
# Dockerfile for building DO apt plugin for linux-arm (64bit).
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Oct 21, 2021 •
edited by jimson-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs updating. In other Dockerfiles as well. Not urgent.. #Resolved

shishirb-MSFT
shishirb-MSFT reviewed Oct 21, 2021
View reviewed changes
build/docker/ubuntu2004/amd64/Dockerfile
# Example:
# docker run -ti --rm --entrypoint=/bin/bash -v D:\do-client-lite:/code -v D:\temp\build_client_lite\arm-linux-debug:/build custom-ubuntu2004-arm64

FROM amd64/ubuntu:20.04
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amd64

We recently came to the conclusion that we'll go native where possible. Isn't a native 20.04 image available in 1ES?

Copy link
Contributor Author

@jimson-msft jimson-msft Oct 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had considered that in an earlier iteration. We can do a native build, but this requires us to setup another 1ES image + another set of pipeline yml files specifically for ubuntu 20.04.

The current 1ES image is named:
do-adu-build-<Semantic Version Number of current (really meaning subsequent) release>

So now we'll have two 1ES images for example, per version:
do-adu-build-ubuntu1804-0.8.0
do-adu-build-ubuntu2004-0.8.0

I don't think it's worth maintaining duplicate vm images for native builds, if we trust that the docker builds are doing what they're supposed to.
Another question may be - if we do native builds for Ubuntu 20.04, do we also run tests there? IMO it's unnecessary since we rely on Ubuntu 1804 for tests.

IMO we should rely on still having a single build image to support all our builds, and only run tests natively, and have CI/CD triggers for a single native build to save on compute resources.

Copy link
Contributor Author

@jimson-msft jimson-msft Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm goign to leave as is for now, if we do want to move to native builds at a later point in time - we still have the option to do so.

shishirb-MSFT
shishirb-MSFT approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@shishirb-MSFT shishirb-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jimson-msft jimson-msft merged commit 65696c3 into develop Oct 21, 2021
@jimson-msft jimson-msft deleted the user/jimson/ubuntu20.04_arm64 branch October 21, 2021 17:25
jimson-msft added a commit that referenced this pull request Oct 22, 2021
@jimson-msft
Support Ubuntu 20.04 on amd64 and arm64 (#96)
eef5888
shishirb-MSFT pushed a commit that referenced this pull request Jan 7, 2022
@jimson-msft @shishirb-MSFT
Support Ubuntu 20.04 on amd64 and arm64 (#96)
3d54d4e
shishirb-MSFT pushed a commit that referenced this pull request Jan 7, 2022
@jimson-msft @shishirb-MSFT
Support Ubuntu 20.04 on amd64 and arm64 (#96)
bd20c49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shishirb-MSFT shishirb-MSFT shishirb-MSFT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimson-msft @shishirb-MSFT