Add a custom SVG REPL so so you can paste or type in an svg and rende… #2728

warren-ms · 2023-03-24T03:28:36Z

…r it live!

Add a test for a very fancy svg using lots of stuff Add a test for radial gradient

Platforms Impacted

iOS
macOS
[ x] win32 (Office)
windows
android

Description of changes

Add a custom SVG REPL so so you can paste or type in an svg and render it live!
Add a test for a very fancy svg using lots of stuff
Add a test for radial gradient
(a summary of the changes made, often organized by file)

Verification

(how the change was tested, including both manual and automated tests)

Before	After
Screenshot or description before this change	Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

…r it live! Add a test for a very fancy svg using lots of stuff Add a test for radial gradient

)

Bumps [prettier](https://github.com/prettier/prettier) from 2.8.6 to 2.8.7. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.6...2.8.7) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [react-native-test-app](https://github.com/microsoft/react-native-test-app) from 2.3.12 to 2.3.13. - [Release notes](https://github.com/microsoft/react-native-test-app/releases) - [Commits](microsoft/react-native-test-app@2.3.12...2.3.13) --- updated-dependencies: - dependency-name: react-native-test-app dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* changed transparentStroke token to background to fix HC border bug * matched subtext bottom margin to label top margin * updated margin between labels * Change files * text margin adjustment * code cleanup * code cleanup * fixed horizontal-stacked alignment and focus rect * code cleanup * replaced labelMarginTop with labelMarginVertical * made win32 specific tokens * implementing new indicator for win32 * fixed merge conflict: * fixed pressed state bug * Change files * Update @fluentui-react-native-tester-40bf90bc-8cef-42c0-9e71-e0f8601e330b.json * added dependency for text margin adjustment * fixed padding issue for horizontal * Update package.json * added empty line * fixed imports and added labelPadding * replaced spec images * fixed focus border and spacing * removed enableFocusRing * updated spec * updated snapshots and removed enableFocusRing from useRadio * removed enableFocusRing from win32 useRadio * added enableFocusRing prop from other platforms * reverted back to transparentStroke token * added tokens for radio size * updated snapshots

* addDot * Change files --------- Co-authored-by: Ankita Raj <ankraj@microsoft.com>

apps/fluent-tester/src/TestComponents/Svg/SvgTest.tsx

* fixed radio variant and radio gap * update screenshots * Change files * updated custom test radio button size * Update CustomizedRadioGroup.tsx * update snapshots

Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.68.13 to 0.68.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) --- updated-dependencies: - dependency-name: "@types/react-native" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [appium-uiautomator2-driver](https://github.com/appium/appium-uiautomator2-driver) from 2.12.4 to 2.12.7. - [Release notes](https://github.com/appium/appium-uiautomator2-driver/releases) - [Changelog](https://github.com/appium/appium-uiautomator2-driver/blob/master/CHANGELOG.md) - [Commits](appium/appium-uiautomator2-driver@v2.12.4...v2.12.7) --- updated-dependencies: - dependency-name: appium-uiautomator2-driver dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

apps/fluent-tester/src/TestComponents/Svg/SvgTest.tsx

…e" (#2731) * On/off text renders with labelPosition=before * Change files * Various changes to switch and test app Remove stray opacity tokens, add comment on height tokens, add extra on/off example in test app. * Change files * Remove on/off text height tokens Also removed shifting of label when labelPosition=above with on/off text * Render two texts always

…id (#2739) * Expand avatar jest tests * Fix default avatar rendering and e2e section * Change files

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.53 to 17.0.56. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Switch docs to reflect latest changes * Change files

* Update appium and node version (#2620) * Update appium beta version to version that doesn't use jsdoc * Update tester_deps yarn.lock * Change files * Update a bunch of things in an attempt to get things working again... * Update node? * diagnose what's up with CI * Introduce .node-version file * remove midgard-yarn * Frozel lockfile * undo yarn please change * Appium driver install added back * Appium driver install added back * Appium driver install added back * Remove flakiness --------- Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> * Add test steps to JS PR * fix dry-run script * temporarily remove buildci step * try node 14.x * build button package first * add build step back * back to node 16 * change npm install version to 9.5.0 * just scope build to button * Add empty .npmignore file * remove extra npm install and dry-run steps * revert azure-pipelines script changes --------- Co-authored-by: Ruriko Araki <ruaraki@microsoft.com> Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.3 to 7.21.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2697) * Add checks for the right bridge * Add checks for the right class * Check bridge instance, not bundleID * Fix opening braces * Update trait collection getters to pass in a viewtag * Change files * Replace RCTExecuteOnMainQueue with RCTUnsafeExecuteOnMainQueueSync * Replace viewTag/rootTag with reactTag * Fix typo * Add attempt to initialize trait collection so that traits returned are never nil * Move initializeTraitCollection code into its own method * Add null check for new traits in appearanceChanged event handler * Add space * Fix typos

* make small changes * Change files * Revert "make small changes" This reverts commit b66f0a2.

* fix npm publish pipeline * Change files

* Update Lage * Remove Lerna

* switch to RN Native Antive Container for animation * Change files

* Tokenize MenuItemRadio * Change files --------- Co-authored-by: chiuam <>

* Define initial tablist package Making a new PR for defining the new package. I will continuously bring code from the old tabs into here. * Change files * Fix lint errors * Bump dependencies * More fixes * Add missing fluent tester dependency * Remove tablist margins file * Change platform status to 'Experimental' * Change use of value to key string * Fix type error * Fix value -> key on test page

Bumps [eslint](https://github.com/eslint/eslint) from 8.41.0 to 8.42.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.41.0...v8.42.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Just modify the hook * Change files

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.8 to 7.22.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.5/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.21.5 to 7.22.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.5/packages/babel-preset-typescript) --- updated-dependencies: - dependency-name: "@babel/preset-typescript" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [semver](https://github.com/npm/node-semver) from 7.5.0 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.5.0...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [metro-config](https://github.com/facebook/metro) from 0.73.9 to 0.73.10. - [Release notes](https://github.com/facebook/metro/releases) - [Changelog](https://github.com/facebook/metro/blob/main/CHANGELOG.md) - [Commits](facebook/metro@v0.73.9...v0.73.10) --- updated-dependencies: - dependency-name: metro-config dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [lage](https://github.com/microsoft/lage) from 2.7.1 to 2.7.2. - [Commits](microsoft/lage@lage_v2.7.1...lage_v2.7.2) --- updated-dependencies: - dependency-name: lage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [useKeyEvent] Make event parameter non optional * Change files

Bumps [metro-react-native-babel-preset](https://github.com/facebook/metro) from 0.73.9 to 0.73.10. - [Release notes](https://github.com/facebook/metro/releases) - [Changelog](https://github.com/facebook/metro/blob/main/CHANGELOG.md) - [Commits](facebook/metro@v0.73.9...v0.73.10) --- updated-dependencies: - dependency-name: metro-react-native-babel-preset dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…r it live! Add a test for a very fancy svg using lots of stuff Add a test for radial gradient

…i-react-native into svg-test-repl2

Add a custom SVG REPL so so you can paste or type in an svg and rende…

458bb21

…r it live! Add a test for a very fancy svg using lots of stuff Add a test for radial gradient

warren-ms requested a review from a team as a code owner March 24, 2023 03:28

warren-ms and others added 12 commits March 23, 2023 21:22

I think testID needs to be on the first item

a7006b1

Change files

c01c9df

[Menu] Fix for keyboard focus is lost when hovering out of a menu (#2727

245ddf4

)

📦 applying package updates ***NO_CI***

99263ad

📦 applying package updates ***NO_CI***

5e4b40b

auto-nits

29068f0

Remove fancy svg test

946bcff

Fix plat bug (#2734)

9fcc6e9

* addDot * Change files --------- Co-authored-by: Ankita Raj <ankraj@microsoft.com>

📦 applying package updates ***NO_CI***

066be54

rurikoaraki reviewed Mar 28, 2023

View reviewed changes

apps/fluent-tester/src/TestComponents/Svg/SvgTest.tsx Outdated Show resolved Hide resolved

rurikoaraki reviewed Mar 28, 2023

View reviewed changes

apps/fluent-tester/src/TestComponents/Svg/SvgTest.tsx Outdated Show resolved Hide resolved

gulnazsayed and others added 4 commits March 30, 2023 12:46

RadioGroup Style Fixes 2.0 (#2740)

87e30e1

* fixed radio variant and radio gap * update screenshots * Change files * updated custom test radio button size * Update CustomizedRadioGroup.tsx * update snapshots

Use callback optimize style

c7d023b

rurikoaraki reviewed Mar 31, 2023

View reviewed changes

apps/fluent-tester/src/TestComponents/Svg/SvgTest.tsx Outdated Show resolved Hide resolved

lawrencewin and others added 9 commits March 31, 2023 14:02

[Avatar] Add more jest tests / Fix default avatar rendering for Andro…

faad458

…id (#2739) * Expand avatar jest tests * Fix default avatar rendering and e2e section * Change files

Update Switch Documentation + Comments (#2746)

00118f4

* Update Switch docs to reflect latest changes * Change files

Manually trigger package updates (#2751)

c54c613

* make small changes * Change files * Revert "make small changes" This reverts commit b66f0a2.

Fix NPM publish pipeline (#2756)

4143b04

* fix npm publish pipeline * Change files

tido64 and others added 29 commits June 12, 2023 19:27

fix: some packages benefit from "sideEffects": false (#2874)

6530042

📦 applying package updates ***NO_CI***

b050416

Update Lage and remove Lerna (#2876)

1842e7f

* Update Lage * Remove Lerna

📦 applying package updates ***NO_CI***

10c316a

<Spinner> switch to RN Native Antive Container for animation (#2847)

9898945

* switch to RN Native Antive Container for animation * Change files

📦 applying package updates ***NO_CI***

ca1e1db

macOS: Tokenize MenuItemRadio (#2878)

7778cc8

* Tokenize MenuItemRadio * Change files --------- Co-authored-by: chiuam <>

📦 applying package updates ***NO_CI***

153ac30

📦 applying package updates ***NO_CI***

5662a78

[macOS] Components don't focus on click (#2879)

30d5533

* Just modify the hook * Change files

📦 applying package updates ***NO_CI***

8556494

[KeyCallback] Make event parameter non optional (#2880)

8fb16fe

* [useKeyEvent] Make event parameter non optional * Change files

📦 applying package updates ***NO_CI***

7f469b3

Add a custom SVG REPL so so you can paste or type in an svg and rende…

2a6b674

…r it live! Add a test for a very fancy svg using lots of stuff Add a test for radial gradient

I think testID needs to be on the first item

2d960d2

Change files

19fdd04

auto-nits

d3d2cb6

Remove fancy svg test

15245f6

Use callback optimize style

2f10421

Use useCallback for some callbacks.

f6428c7

Merge branch 'svg-test-repl2' of https://github.com/microsoft/fluentu…

49d8a5f

…i-react-native into svg-test-repl2

warren-ms merged commit 4cb0e46 into main Jun 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a custom SVG REPL so so you can paste or type in an svg and rende… #2728

Add a custom SVG REPL so so you can paste or type in an svg and rende… #2728

Uh oh!

warren-ms commented Mar 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Add a custom SVG REPL so so you can paste or type in an svg and rende… #2728

Add a custom SVG REPL so so you can paste or type in an svg and rende… #2728

Uh oh!

Conversation

warren-ms commented Mar 24, 2023

Platforms Impacted

Description of changes

Verification

Pull request checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants