-
Notifications
You must be signed in to change notification settings - Fork 170
Properly render switch on/off text when labelPosition prop = "before"
#2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPatBoyd
requested changes
Mar 24, 2023
Remove stray opacity tokens, add comment on height tokens, add extra on/off example in test app.
Also removed shifting of label when labelPosition=above with on/off text
PPatBoyd
approved these changes
Mar 31, 2023
10 tasks
warren-ms
added a commit
that referenced
this pull request
Jun 21, 2023
#2728) * Add a custom SVG REPL so so you can paste or type in an svg and render it live! Add a test for a very fancy svg using lots of stuff Add a test for radial gradient * I think testID needs to be on the first item * Change files * [Menu] Fix for keyboard focus is lost when hovering out of a menu (#2727) * 📦 applying package updates ***NO_CI*** * Bump prettier from 2.8.6 to 2.8.7 (#2730) Bumps [prettier](https://github.com/prettier/prettier) from 2.8.6 to 2.8.7. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.8.6...2.8.7) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-native-test-app from 2.3.12 to 2.3.13 (#2729) Bumps [react-native-test-app](https://github.com/microsoft/react-native-test-app) from 2.3.12 to 2.3.13. - [Release notes](https://github.com/microsoft/react-native-test-app/releases) - [Commits](https://github.com/microsoft/react-native-test-app/compare/2.3.12...2.3.13) --- updated-dependencies: - dependency-name: react-native-test-app dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * RadioGroup Style Fixes (#2552) * changed transparentStroke token to background to fix HC border bug * matched subtext bottom margin to label top margin * updated margin between labels * Change files * text margin adjustment * code cleanup * code cleanup * fixed horizontal-stacked alignment and focus rect * code cleanup * replaced labelMarginTop with labelMarginVertical * made win32 specific tokens * implementing new indicator for win32 * fixed merge conflict: * fixed pressed state bug * Change files * Update @fluentui-react-native-tester-40bf90bc-8cef-42c0-9e71-e0f8601e330b.json * added dependency for text margin adjustment * fixed padding issue for horizontal * Update package.json * added empty line * fixed imports and added labelPadding * replaced spec images * fixed focus border and spacing * removed enableFocusRing * updated spec * updated snapshots and removed enableFocusRing from useRadio * removed enableFocusRing from win32 useRadio * added enableFocusRing prop from other platforms * reverted back to transparentStroke token * added tokens for radio size * updated snapshots * 📦 applying package updates ***NO_CI*** * auto-nits * Remove fancy svg test * Fix plat bug (#2734) * addDot * Change files --------- Co-authored-by: Ankita Raj <ankraj@microsoft.com> * 📦 applying package updates ***NO_CI*** * RadioGroup Style Fixes 2.0 (#2740) * fixed radio variant and radio gap * update screenshots * Change files * updated custom test radio button size * Update CustomizedRadioGroup.tsx * update snapshots * Use callback optimize style * Bump @types/react-native from 0.68.13 to 0.68.14 (#2735) Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.68.13 to 0.68.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) --- updated-dependencies: - dependency-name: "@types/react-native" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump appium-uiautomator2-driver from 2.12.4 to 2.12.7 (#2737) Bumps [appium-uiautomator2-driver](https://github.com/appium/appium-uiautomator2-driver) from 2.12.4 to 2.12.7. - [Release notes](https://github.com/appium/appium-uiautomator2-driver/releases) - [Changelog](https://github.com/appium/appium-uiautomator2-driver/blob/master/CHANGELOG.md) - [Commits](https://github.com/appium/appium-uiautomator2-driver/compare/v2.12.4...v2.12.7) --- updated-dependencies: - dependency-name: appium-uiautomator2-driver dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Properly render switch on/off text when `labelPosition` prop = "before" (#2731) * On/off text renders with labelPosition=before * Change files * Various changes to switch and test app Remove stray opacity tokens, add comment on height tokens, add extra on/off example in test app. * Change files * Remove on/off text height tokens Also removed shifting of label when labelPosition=above with on/off text * Render two texts always * [Avatar] Add more jest tests / Fix default avatar rendering for Android (#2739) * Expand avatar jest tests * Fix default avatar rendering and e2e section * Change files * Bump @types/react from 17.0.53 to 17.0.56 (#2748) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.53 to 17.0.56. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Switch Documentation + Comments (#2746) * Update Switch docs to reflect latest changes * Change files * Update appium and node version (#2745) * Update appium and node version (#2620) * Update appium beta version to version that doesn't use jsdoc * Update tester_deps yarn.lock * Change files * Update a bunch of things in an attempt to get things working again... * Update node? * diagnose what's up with CI * Introduce .node-version file * remove midgard-yarn * Frozel lockfile * undo yarn please change * Appium driver install added back * Appium driver install added back * Appium driver install added back * Remove flakiness --------- Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> * Add test steps to JS PR * fix dry-run script * temporarily remove buildci step * try node 14.x * build button package first * add build step back * back to node 16 * change npm install version to 9.5.0 * just scope build to button * Add empty .npmignore file * remove extra npm install and dry-run steps * revert azure-pipelines script changes --------- Co-authored-by: Ruriko Araki <ruaraki@microsoft.com> Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> * Bump @babel/core from 7.21.3 to 7.21.4 (#2743) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.3 to 7.21.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * iOS FRNAppearanceAdditions: support for multiple trait collections (#2697) * Add checks for the right bridge * Add checks for the right class * Check bridge instance, not bundleID * Fix opening braces * Update trait collection getters to pass in a viewtag * Change files * Replace RCTExecuteOnMainQueue with RCTUnsafeExecuteOnMainQueueSync * Replace viewTag/rootTag with reactTag * Fix typo * Add attempt to initialize trait collection so that traits returned are never nil * Move initializeTraitCollection code into its own method * Add null check for new traits in appearanceChanged event handler * Add space * Fix typos * Manually trigger package updates (#2751) * make small changes * Change files * Revert "make small changes" This reverts commit b66f0a25ee0edaf72026a54bb478319be668cd9c. * Fix NPM publish pipeline (#2756) * fix npm publish pipeline * Change files * 📦 applying package updates ***NO_CI*** * Bump @fortawesome/fontawesome-svg-core from 6.3.0 to 6.4.0 (#2750) Bumps [@fortawesome/fontawesome-svg-core](https://github.com/FortAwesome/Font-Awesome) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases) - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md) - [Commits](https://github.com/FortAwesome/Font-Awesome/compare/6.3.0...6.4.0) --- updated-dependencies: - dependency-name: "@fortawesome/fontawesome-svg-core" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/preset-env from 7.20.2 to 7.21.4 (#2744) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.20.2 to 7.21.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * <Spinner win32> - Add TrackSvg and implement platform specific design (#2747) * add tracker svg for win32 * Change files * define useSpinner hook * add sizes as tokens * Fix align-deps warnings + upgrade react-native-test-app (#2753) * align-deps: Fix warnigns and issues * Upgrade react-native-test-app * Change files * 📦 applying package updates ***NO_CI*** * [Text field] New component for Android (#2732) * Basic structure for Input * Fix build * Complete styling * Fix build * Update structure * Added error, focused and icon states * Added typing/filled states and snapshots * Fixes * Add support for different keyboard types * Added accessory icon onPress support and disabled mode * Fix double click required to clear input * Fix input dependency in tester * Rename dismissIcon, add docs for props * Change files * Change input package to publish * Change files * Update snaps * Fix keyboard closing on accessory button click * Fix depcheck * Update snaps after bug fix * Accessibility and placeholder fixes * Clean code * Make dismiss icon default in the component * Add controlled & error exmaples to tester * Update package.json * Fix resize behaviour of text input and add width prop * Updated tests and snaps * Fix depcheck * Resolve comments * Remove from ios tester * Update comment * 📦 applying package updates ***NO_CI*** * Bump @rnx-kit/cli from 0.16.4 to 0.16.6 (#2760) Bumps [@rnx-kit/cli](https://github.com/microsoft/rnx-kit/tree/HEAD/packages/cli) from 0.16.4 to 0.16.6. - [Release notes](https://github.com/microsoft/rnx-kit/releases) - [Changelog](https://github.com/microsoft/rnx-kit/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/microsoft/rnx-kit/commits/@rnx-kit/cli@0.16.6/packages/cli) --- updated-dependencies: - dependency-name: "@rnx-kit/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update yarn.lock (#2763) * [Button] Fix onLayout (#2762) * Fix onLayout * Change files * Bump markdown-link-check from 3.10.3 to 3.11.1 (#2761) Bumps [markdown-link-check](https://github.com/tcort/markdown-link-check) from 3.10.3 to 3.11.1. - [Release notes](https://github.com/tcort/markdown-link-check/releases) - [Changelog](https://github.com/tcort/markdown-link-check/blob/master/CHANGELOG.md) - [Commits](https://github.com/tcort/markdown-link-check/compare/v3.10.3...v3.11.1) --- updated-dependencies: - dependency-name: markdown-link-check dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 7.3.8 to 7.4.0 (#2759) Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.4.0. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/node-semver/compare/v7.3.8...v7.4.0) --- updated-dependencies: - dependency-name: semver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-native-windows from 0.68.30 to 0.68.32 (#2758) Bumps [react-native-windows](https://github.com/microsoft/react-native-windows/tree/HEAD/vnext) from 0.68.30 to 0.68.32. - [Release notes](https://github.com/microsoft/react-native-windows/releases) - [Changelog](https://github.com/microsoft/react-native-windows/blob/react-native-windows_v0.68.32/vnext/CHANGELOG.md) - [Commits](https://github.com/microsoft/react-native-windows/commits/react-native-windows_v0.68.32/vnext) --- updated-dependencies: - dependency-name: react-native-windows dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Menu - Android] Implement Menu for Android (#2715) * menu android * this is fix: modify this * this is fix: modify this * working up down pos * refactor to android useMenu hook * design fixes * add animated scrollview * add tokens for android * fix tokens * fix menu item text * elevation working * complete menuitem divider * complete menuitem with icon implem * checkbox items changes * add checkbox to android * fix radio group item crash * state checked working * menu radio strcutured * fix tester and radio complete * fix icon margin end and alginment for hascheckmark props * fix merge conflict * Change files * make inside checkbox/radio non focusable * fix: build pipeline failure * refactor out modal to menupopover * fix types & structure - make review ready * add only android props * fix according to design * fix overflow of text outside menu * fix controlled menu component * fix left boundary crash * address pr feedbacks * address pr feedbacks * refactor out radio to seperate component * address feedbacks * refactor to menucallout component * remove depen oon divider and localize types * address feedback: refactor types, male common code for menu * address feedbacks: add comments and fix typo * fix: typo preset to press retention * fix: address feedback ,seeprate out RadioItem from CheckboxItem, per platform file for renderMenu * rename radio states variable & remove checkbox from win32 styling * Bump @babel/preset-typescript from 7.21.0 to 7.21.4 (#2749) Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.21.0 to 7.21.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-preset-typescript) --- updated-dependencies: - dependency-name: "@babel/preset-typescript" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix pipeline (#2764) * Fix the pipeline * Change files * Delete dependencies in component generator since they're out of date * 📦 applying package updates ***NO_CI*** * [Menu] SPEC.md and Docs update (#2776) * add screenshots and doc update * add blackbox example and remove unused tokens * Change files * add: include macOS in platforms supports * fix spelling typos * address reviews: add macos to Menucallout docs * fix: add useCallback * fix: move switch change function to usecallback * fix:address feedbacks: add useCallback * 📦 applying package updates ***NO_CI*** * Bump react-native-test-app from 2.3.16 to 2.4.0 (#2774) * Bump react-native-test-app from 2.3.16 to 2.4.0 Bumps [react-native-test-app](https://github.com/microsoft/react-native-test-app) from 2.3.16 to 2.4.0. - [Release notes](https://github.com/microsoft/react-native-test-app/releases) - [Commits](https://github.com/microsoft/react-native-test-app/compare/2.3.16...2.4.0) --- updated-dependencies: - dependency-name: react-native-test-app dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix android build issue * Change files --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ayush Singh <ayushsinghs@yahoo.in> * 📦 applying package updates ***NO_CI*** * Bump eslint from 8.36.0 to 8.38.0 (#2767) Bumps [eslint](https://github.com/eslint/eslint) from 8.36.0 to 8.38.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.36.0...v8.38.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-native-macos from 0.68.68 to 0.68.70 (#2773) Bumps [react-native-macos](https://github.com/microsoft/react-native-macos) from 0.68.68 to 0.68.70. - [Release notes](https://github.com/microsoft/react-native-macos/releases) - [Changelog](https://github.com/microsoft/react-native-macos/blob/main/CHANGELOG.md) - [Commits](https://github.com/microsoft/react-native-macos/compare/v0.68.68...v0.68.70) --- updated-dependencies: - dependency-name: react-native-macos dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump appium-uiautomator2-driver from 2.12.4 to 2.15.0 (#2777) Bumps [appium-uiautomator2-driver](https://github.com/appium/appium-uiautomator2-driver) from 2.12.4 to 2.15.0. - [Release notes](https://github.com/appium/appium-uiautomator2-driver/releases) - [Changelog](https://github.com/appium/appium-uiautomator2-driver/blob/master/CHANGELOG.md) - [Commits](https://github.com/appium/appium-uiautomator2-driver/compare/v2.12.4...v2.15.0) --- updated-dependencies: - dependency-name: appium-uiautomator2-driver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Addons on Text Input - Functionality / Docs / Tests (#2775) * Adding onFocus icon and keyboard avoiding view sample * Update tester samples, remove accessoryViews when text is empty, change icon during error * Rename secondaryText to accessoryText * Update spec for input * Change accessoryView rendering logic * Expand jest tests * Make input get focus when using keyboard to clear text * Add accessibility behaviour for textField and accessoryIcon * Add e2e tests * Change files * Fix repo link * Fix import * Attempt to fix input e2e test * Fix for E2E * Make E2E input editable * Change mobile typing method * Increase tappable area * Replace pressRetensionOffset with hitSlop * Replace strings with consts * Rename icon to defaultIcon * [Radio] A11y fix - Demonstrate radio announcing unselected on Android (#2757) * Demo unselected radio announcement on Android * Change files * 📦 applying package updates ***NO_CI*** * Bump @react-native-picker/picker from 2.4.9 to 2.4.10 (#2783) Bumps [@react-native-picker/picker](https://github.com/react-native-picker/picker) from 2.4.9 to 2.4.10. - [Release notes](https://github.com/react-native-picker/picker/releases) - [Changelog](https://github.com/react-native-picker/picker/blob/master/.releaserc) - [Commits](https://github.com/react-native-picker/picker/compare/v2.4.9...v2.4.10) --- updated-dependencies: - dependency-name: "@react-native-picker/picker" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 📦 applying package updates ***NO_CI*** * [Menu] Enable pointer capture on MenuPopover to be overridden (#2785) * enable pointer capture to be overwritten * Change files * update change message * 📦 applying package updates ***NO_CI*** * Bump react-native-test-app from 2.4.0 to 2.5.0 (#2780) Bumps [react-native-test-app](https://github.com/microsoft/react-native-test-app) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/microsoft/react-native-test-app/releases) - [Commits](https://github.com/microsoft/react-native-test-app/compare/2.4.0...2.5.0) --- updated-dependencies: - dependency-name: react-native-test-app dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump appium-uiautomator2-driver from 2.15.0 to 2.17.0 (#2781) Bumps [appium-uiautomator2-driver](https://github.com/appium/appium-uiautomator2-driver) from 2.15.0 to 2.17.0. - [Release notes](https://github.com/appium/appium-uiautomator2-driver/releases) - [Changelog](https://github.com/appium/appium-uiautomator2-driver/blob/master/CHANGELOG.md) - [Commits](https://github.com/appium/appium-uiautomator2-driver/compare/v2.15.0...v2.17.0) --- updated-dependencies: - dependency-name: appium-uiautomator2-driver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/enzyme from 3.10.12 to 3.10.13 (#2782) Bumps [@types/enzyme](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/enzyme) from 3.10.12 to 3.10.13. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/enzyme) --- updated-dependencies: - dependency-name: "@types/enzyme" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add Menu "Home" and "End" key functionality (#2701) * Add janky home + end functionality, clean up later * Change focus behavior for mac and ios Focus on mac and ios now go to the first and last ENABLED element rather than just the first and last. * Address nits * Change files * 📦 applying package updates ***NO_CI*** * Bump @rnx-kit/cli from 0.16.6 to 0.16.8 (#2790) Bumps [@rnx-kit/cli](https://github.com/microsoft/rnx-kit/tree/HEAD/packages/cli) from 0.16.6 to 0.16.8. - [Release notes](https://github.com/microsoft/rnx-kit/releases) - [Changelog](https://github.com/microsoft/rnx-kit/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/microsoft/rnx-kit/commits/@rnx-kit/cli@0.16.8/packages/cli) --- updated-dependencies: - dependency-name: "@rnx-kit/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 7.4.0 to 7.5.0 (#2789) Bumps [semver](https://github.com/npm/node-semver) from 7.4.0 to 7.5.0. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/node-semver/compare/v7.4.0...v7.5.0) --- updated-dependencies: - dependency-name: semver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump beachball from 2.31.12 to 2.31.13 (#2788) Bumps [beachball](https://github.com/microsoft/beachball) from 2.31.12 to 2.31.13. - [Release notes](https://github.com/microsoft/beachball/releases) - [Changelog](https://github.com/microsoft/beachball/blob/master/CHANGELOG.md) - [Commits](https://github.com/microsoft/beachball/compare/beachball_v2.31.12...beachball_v2.31.13) --- updated-dependencies: - dependency-name: beachball dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @fortawesome/free-solid-svg-icons from 6.3.0 to 6.4.0 (#2787) Bumps [@fortawesome/free-solid-svg-icons](https://github.com/FortAwesome/Font-Awesome) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases) - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md) - [Commits](https://github.com/FortAwesome/Font-Awesome/compare/6.3.0...6.4.0) --- updated-dependencies: - dependency-name: "@fortawesome/free-solid-svg-icons" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Button] Fix win32 subtle button coloring (#2791) * Fix subtle button colors * Change files * 📦 applying package updates ***NO_CI*** * Don't bundle in JS PR (#2792) * Don't bundle in JS PR * Update azure-pipelines.yml comment * Bump @types/react from 17.0.56 to 17.0.58 (#2771) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 17.0.56 to 17.0.58. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prettier from 2.8.7 to 2.8.8 (#2794) Bumps [prettier](https://github.com/prettier/prettier) from 2.8.7 to 2.8.8. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.8.7...2.8.8) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Conditionally set enableFocusRing when hovered and keyboarded focused. (#2798) * fixed hovered and focused visuals * remove hovered state on list context * Change files * 📦 applying package updates ***NO_CI*** * fix: security alerts issues (#2802) * Bug Fix - Enabling Voice Access for "Press to Alert" button in Pressable Test (#2804) * added accessibility props * updated label * Change files * 📦 applying package updates ***NO_CI*** * Bump eslint from 8.38.0 to 8.39.0 (#2795) Bumps [eslint](https://github.com/eslint/eslint) from 8.38.0 to 8.39.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.38.0...v8.39.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump appium-uiautomator2-driver from 2.17.0 to 2.19.0 (#2803) Bumps [appium-uiautomator2-driver](https://github.com/appium/appium-uiautomator2-driver) from 2.17.0 to 2.19.0. - [Release notes](https://github.com/appium/appium-uiautomator2-driver/releases) - [Changelog](https://github.com/appium/appium-uiautomator2-driver/blob/master/CHANGELOG.md) - [Commits](https://github.com/appium/appium-uiautomator2-driver/compare/v2.17.0...v2.19.0) --- updated-dependencies: - dependency-name: appium-uiautomator2-driver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Menu] Implement N of M on submenu trigger (#2801) * set n of m on submenu trigger * Change files * address comments * remove useMemo and just assign props * Remove button from within menu * 📦 applying package updates ***NO_CI*** * [Menu] E2E test for Menu Android (#2786) * test: e2e init for android menu * Change files * 📦 applying package updates ***NO_CI*** * Bump @rnx-kit/metro-config from 1.3.5 to 1.3.6 (#2796) Bumps [@rnx-kit/metro-config](https://github.com/microsoft/rnx-kit/tree/HEAD/packages/metro-config) from 1.3.5 to 1.3.6. - [Release notes](https://github.com/microsoft/rnx-kit/releases) - [Changelog](https://github.com/microsoft/rnx-kit/blob/main/packages/metro-config/CHANGELOG.md) - [Commits](https://github.com/microsoft/rnx-kit/commits/@rnx-kit/metro-config@1.3.6/packages/metro-config) --- updated-dependencies: - dependency-name: "@rnx-kit/metro-config" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @rnx-kit/jest-preset from 0.1.13 to 0.1.14 (#2799) Bumps [@rnx-kit/jest-preset](https://github.com/microsoft/rnx-kit/tree/HEAD/packages/jest-preset) from 0.1.13 to 0.1.14. - [Release notes](https://github.com/microsoft/rnx-kit/releases) - [Changelog](https://github.com/microsoft/rnx-kit/blob/main/packages/jest-preset/CHANGELOG.md) - [Commits](https://github.com/microsoft/rnx-kit/commits/@rnx-kit/jest-preset@0.1.14/packages/jest-preset) --- updated-dependencies: - dependency-name: "@rnx-kit/jest-preset" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @rnx-kit/eslint-plugin from 0.4.1 to 0.4.2 (#2800) Bumps [@rnx-kit/eslint-plugin](https://github.com/microsoft/rnx-kit/tree/HEAD/packages/eslint-plugin) from 0.4.1 to 0.4.2. - [Release notes](https://github.com/microsoft/rnx-kit/releases) - [Changelog](https://github.com/microsoft/rnx-kit/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/microsoft/rnx-kit/commits/@rnx-kit/eslint-plugin@0.4.2/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@rnx-kit/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-native-test-app from 2.5.0 to 2.5.2 (#2808) Bumps [react-native-test-app](https://github.com/microsoft/react-native-test-app) from 2.5.0 to 2.5.2. - [Release notes](https://github.com/microsoft/react-native-test-app/releases) - [Commits](https://github.com/microsoft/react-native-test-app/compare/2.5.0...2.5.2) --- updated-dependencies: - dependency-name: react-native-test-app dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * <Spinner>add spinner tail svg without native animation - win32 (#2809) * add spinner tail svg without native animation * Change files * remove comment * 📦 applying package updates ***NO_CI*** * Add bundling in win32 publish (#2812) * Fix repo link to unblock PR checks (#2818) * Update apple developer repo link * Change files * Found more accurate link * 📦 applying package updates ***NO_CI*** * Bump design token packages to version 0.49.0 (#2766) * Update package.json + yarn.lock * Update mapPipelintToTheme and AliasColorTokens interface * Make temporary mapPipelineToTheme.macos.ts (copy of old mapPipelineToTheme.ts) * Fix typo in mapPipelineToTheme.ios.ts * Update snapshots * Add null check in macOS code since it gets run for both macOS/windows tokens * Change files * Mark red colors as deprecated * Update to 0.48.0, which includes string fix * Update snapshots * Update to 0.49.0, which includes string fix 2 * Update snapshots * 📦 applying package updates ***NO_CI*** * Use useCallback for some callbacks. * Use Xcode 14.2 in ADO pipelines (#2811) * Bump @react-native-community/slider from 4.4.0 to 4.4.2 Bumps [@react-native-community/slider](https://github.com/callstack/react-native-slider) from 4.4.0 to 4.4.2. - [Release notes](https://github.com/callstack/react-native-slider/releases) - [Commits](https://github.com/callstack/react-native-slider/compare/v4.4.0...v4.4.2) --- updated-dependencies: - dependency-name: "@react-native-community/slider" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Use Xcode 14.2 in ADO pipelines * Fix simuator runtime * 16.0 runtime is invalid, but apparently 16.2 is ok * Try 16.2 for appium * Change files --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> * 📦 applying package updates ***NO_CI*** * [Avatar] Fix anonymous icon svg rendered size (#2817) * Update fallback icon logic * Update snaps * Change files * 📦 applying package updates ***NO_CI*** * Update iOS menu picker to use @react-native-menu/menu instead of @react-native-picker/picker (#2822) * Update MenuPicker to use a MenuView instead of Picker * Add vmargins to avatar styledPickers * Fix typo * Add chevron icon that changes color depending on light/dark mode * Change files * Split ios/android MenuPicker into separate files * Update some comments * 📦 applying package updates ***NO_CI*** * [Input] Change default svg to component - Android (#2829) * Change svg to component * Change files * Refactor into assets folder * 📦 applying package updates ***NO_CI*** * Bump markdown-link-check from 3.11.1 to 3.11.2 (#2815) Bumps [markdown-link-check](https://github.com/tcort/markdown-link-check) from 3.11.1 to 3.11.2. - [Release notes](https://github.com/tcort/markdown-link-check/releases) - [Changelog](https://github.com/tcort/markdown-link-check/blob/master/CHANGELOG.md) - [Commits](https://github.com/tcort/markdown-link-check/compare/v3.11.1...v3.11.2) --- updated-dependencies: - dependency-name: markdown-link-check dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump appium-uiautomator2-driver from 2.19.0 to 2.24.0 (#2826) Bumps [appium-uiautomator2-driver](https://github.com/appium/appium-uiautomator2-driver) from 2.19.0 to 2.24.0. - [Release notes](https://github.com/appium/appium-uiautomator2-driver/releases) - [Changelog](https://github.com/appium/appium-uiautomator2-driver/blob/master/CHANGELOG.md) - [Commits](https://github.com/appium/appium-uiautomator2-driver/compare/v2.19.0...v2.24.0) --- updated-dependencies: - dependency-name: appium-uiautomator2-driver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Avatar] A11y talkback fixes enabling status announcements (#2797) * fix talkbalks enabling status * Change files * fix: remove extra spacing * revert non localize changes & fix typos * fix: update snapshots * fix: add shorthand operator * 📦 applying package updates ***NO_CI*** * [Tester] Fix picker - Android (#2830) * Fix android picker * Change files * 📦 applying package updates ***NO_CI*** * [Drawer] Deprecating and removing non working Native Android Drawer (#2828) * remove non working drawer * Change files * update docs to remove drawer references * 📦 applying package updates ***NO_CI*** * [RadioGroup] Removed horizontal layouts from win32 tester (#2805) * removed other layouts tests for win32 * updated spec * fixed prop comments in spec * Change files * added platform check for win32 * added android check * fixed import type * updated snapshots * default layout * updated snapshot * layer checks * comments clean up * update snapshots * 📦 applying package updates ***NO_CI*** * Migrate RadioGroupV1 from experimental to components folder (#2741) * created legacy folder * moved assets, radio, radiogroup folders * fixed components package.json * updated experimental package.json * updated components tsconfig * updated components index.ts * updated experimental index.ts * finished updating experimental folder and moved documentation * fixed imports in tests * fixed imports * Change files * updated import order * update snapshots * added radiogroup dependency * updated snapshots * updating dependency * 📦 applying package updates ***NO_CI*** * fix: windows bump WindowsTargetPlatformMinVersion for Expander (#2827) * bump expander's windows min * Change files * 📦 applying package updates ***NO_CI*** * macOS: Implement MenuGroup (#2824) * 📦 applying package updates ***NO_CI*** * [Drawer - Android] Implement Structure and Basic Working Drawer (#2834) * feat: initial structuring for v1 js drawer * adding by drawer working without pan responder * add: top drawer, dragger visibility,position fix * fix: working drawer with position left,right,bottom * refactoring into slots & useDrawer & stlying * fix: styling seperation and tokenization start * add: tokens for handle,modal.content * fix: close animation working - usage of internal visible * clean up types and unused code * rename DrawerV1 to Drawer as old code is removed * add: useCallbacks to func * Change files * fix: build break & add tests file * fix: first app open not opening drawer * chore: add tokens, opacity & fix few stylings * address feedbacks: make tokens for positions, cache tokens & remove unused code * add android platform check * rename backdrop to scrim to match native naming * add: adress spec review feedbacks and changes to match native android * update tests * spec review changes & feecbacks * 📦 applying package updates ***NO_CI*** * Bump @babel/core from 7.21.4 to 7.21.8 (#2819) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.4 to 7.21.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.8/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update design-tokens to 0.50.0 - mobile accessible stroke tokens + macOS status tokens (#2825) * Update design-tokens to 0.50.0 * Add macOS status tokens and accessible mobile stroke colors to AliasColorTokens interface * Update mapPipelineToTheme * Remove red colors from appleColors.macOS.ts * Update snapshot * Change files * 📦 applying package updates ***NO_CI*** * Bump eslint from 8.39.0 to 8.41.0 (#2837) Bumps [eslint](https://github.com/eslint/eslint) from 8.39.0 to 8.41.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.39.0...v8.41.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/preset-react from 7.18.6 to 7.22.3 (#2848) Bumps [@babel/preset-react](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-react) from 7.18.6 to 7.22.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.3/packages/babel-preset-react) --- updated-dependencies: - dependency-name: "@babel/preset-react" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/preset-typescript from 7.21.4 to 7.21.5 (#2831) Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.21.4 to 7.21.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.21.5/packages/babel-preset-typescript) --- updated-dependencies: - dependency-name: "@babel/preset-typescript" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump beachball from 2.31.13 to 2.33.3 (#2846) Bumps [beachball](https://github.com/microsoft/beachball) from 2.31.13 to 2.33.3. - [Changelog](https://github.com/microsoft/beachball/blob/master/CHANGELOG.md) - [Commits](https://github.com/microsoft/beachball/compare/beachball_v2.31.13...beachball_v2.33.3) --- updated-dependencies: - dependency-name: beachball dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Execute focus before calling callback (#2849) * Execute focus before calling callback * Change files * Update to React Native 0.71 (#2754) * align-deps: Fix warnigns and issues * Upgrade react-native-test-app * Update align-deps to 0.71 * Fix JS build issues * Try build apple * Change files * babel runtime classic * resolve react-native-svg to 13.9.0 * Fix more bundling errors * Change files * tests * update package versions * Get jest tests working * Change files * Bump rnwin32 version and clean up imports * fix issue which caused a ts-ignore to inserted * Try using a specific image for windows PR * Updated yml * try OE-OfficePublic * update pool * another pipeline fix * Update adapters * Fix UWP tester app * Fix android PR * bump RNW version, and use AutomationProperties.AutomationId for mapping from AccessibilityLabel * Revert back to name - and bump rn-macos * bump RNW * bump @office-iss/rex-win32 version * Try a accessibilty fix for RNW... * undo previous UWP fix attempt * Update react-native-windows * fix * Change files * align-deps on drawer * Move new components to classic runtime * Test * Update iOS wdio config * Revert change that broke windows e2e tests * Use iOS 16.2 * Match iPhone simulators * Fix ActivityIndicator * Disable Drawer test * Specify simulator in CI * Fix yml * Update snapshot * Update azure-pipelines.yml * Update azure-pipelines.yml * Update azure-pipelines.yml --------- Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Andrew Coates <acoates@microsoft.com> * 📦 applying package updates ***NO_CI*** * [Android] Reduce flaky tests (#2838) * Handle flaky tests Android * Change files * 📦 applying package updates ***NO_CI*** * Bump fast-xml-parser (#2862) * bumping package * remove from package.json and update only 4.1.3 * Bump @office-iss/react-native-win32 (#2865) * Bump version of win32 being used * Change files * 📦 applying package updates ***NO_CI*** * [E2E tests] Update Input/Checkbox test waiters (#2863) * Fix test * Change files * Checkbox waiters * Input Waiters * 📦 applying package updates ***NO_CI*** * fix: fix packages depending on `use-subscription` (#2868) * Bump react-native-macos from 0.71.8 to 0.71.11 (#2869) Bumps [react-native-macos](https://github.com/microsoft/react-native-macos) from 0.71.8 to 0.71.11. - [Release notes](https://github.com/microsoft/react-native-macos/releases) - [Changelog](https://github.com/microsoft/react-native-macos/blob/main/CHANGELOG.md) - [Commits](https://github.com/microsoft/react-native-macos/compare/v0.71.8...v0.71.11) --- updated-dependencies: - dependency-name: react-native-macos dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @types/jest from 29.5.1 to 29.5.2 (#2852) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.1 to 29.5.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) --- updated-dependencies: - dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 📦 applying package updates ***NO_CI*** * Bump react-native from 0.71.6 to 0.71.10 (#2864) Bumps [react-native](https://github.com/facebook/react-native) from 0.71.6 to 0.71.10. - [Release notes](https://github.com/facebook/react-native/releases) - [Changelog](https://github.com/facebook/react-native/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react-native/compare/v0.71.6...v0.71.10) --- updated-dependencies: - dependency-name: react-native dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump react-native-windows from 0.71.14 to 0.71.16 (#2859) Bumps [react-native-windows](https://github.com/microsoft/react-native-windows/tree/HEAD/vnext) from 0.71.14 to 0.71.16. - [Release notes](https://github.com/microsoft/react-native-windows/releases) - [Changelog](https://github.com/microsoft/react-native-windows/blob/react-native-windows_v0.71.16/vnext/CHANGELOG.md) - [Commits](https://github.com/microsoft/react-native-windows/commits/react-native-windows_v0.71.16/vnext) --- updated-dependencies: - dependency-name: react-native-windows dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump fast-xml-parser from 4.1.1 to 4.2.4 (#2858) Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.1.1 to 4.2.4. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](https://github.com/NaturalIntelligence/fast-xml-parser/commits) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Callout][macOS] Implement setInitialFocus (#2866) * Change files * [Callout] Implement setInitialFocus for macOS * Update Callout.types.ts * Update useMenuPopover.ts * Update CalloutView.swift * 📦 applying package updates ***NO_CI*** * [Tree shaking] Fix import and update ESlint rules (#2851) * Attempt to tree shake * fix config * Undo temp changes * Changes for treeshake to work * Fix babel * Fix babel 2 * Change files * Change files * Fix windows PR * Fix e2e * Change files * Fix e2e, retain tree shaking * Make win32 use commonjs * Change files * Change PR to handle tree shake enabling changes alone * Remove extra export --------- Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com> * fix: some packages benefit from `"sideEffects": false` (#2874) * 📦 applying package updates ***NO_CI*** * Update Lage and remove Lerna (#2876) * Update Lage * Remove Lerna * 📦 applying package updates ***NO_CI*** * <Spinner> switch to RN Native Antive Container for animation (#2847) * switch to RN Native Antive Container for animation * Change files * 📦 applying package updates ***NO_CI*** * macOS: Tokenize MenuItemRadio (#2878) * Tokenize MenuItemRadio * Change files --------- Co-authored-by: chiuam <> * 📦 applying package updates ***NO_CI*** * Define TabList Package (#2861) * Define initial tablist package Making a new PR for defining the new package. I will continuously bring code from the old tabs into here. * Change files * Fix lint errors * Bump dependencies * More fixes * Add missing fluent tester dependency * Remove tablist margins file * Change platform status to 'Experimental' * Change use of value to key string * Fix type error * Fix value -> key on test page * 📦 applying package updates ***NO_CI*** * Bump eslint from 8.41.0 to 8.42.0 (#2855) Bumps [eslint](https://github.com/eslint/eslint) from 8.41.0 to 8.42.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.41.0...v8.42.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [macOS] Components don't focus on click (#2879) * Just modify the hook * Change files * 📦 applying package updates ***NO_CI*** * Bump @babel/core from 7.21.8 to 7.22.5 (#2873) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.21.8 to 7.22.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.5/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/preset-typescript from 7.21.5 to 7.22.5 (#2871) Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.21.5 to 7.22.5. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.22.5/packages/babel-preset-typescript) --- updated-dependencies: - dependency-name: "@babel/preset-typescript" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 7.5.0 to 7.5.2 (#2882) Bumps [semver](https://github.com/npm/node-semver) from 7.5.0 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/node-semver/compare/v7.5.0...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump metro-config from 0.73.9 to 0.73.10 (#2883) Bumps [metro-config](https://github.com/facebook/metro) from 0.73.9 to 0.73.10. - [Release notes](https://github.com/facebook/metro/releases) - [Changelog](https://github.com/facebook/metro/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/metro/compare/v0.73.9...v0.73.10) --- updated-dependencies: - dependency-name: metro-config dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump lage from 2.7.1 to 2.7.2 (#2884) Bumps [lage](https://github.com/microsoft/lage) from 2.7.1 to 2.7.2. - [Commits](https://github.com/microsoft/lage/compare/lage_v2.7.1...lage_v2.7.2) --- updated-dependencies: - dependency-name: lage dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [KeyCallback] Make event parameter non optional (#2880) * [useKeyEvent] Make event parameter non optional * Change files * 📦 applying package updates ***NO_CI*** * Bump metro-react-native-babel-preset from 0.73.9 to 0.73.10 (#2870) Bumps [metro-react-native-babel-preset](https://github.com/facebook/metro) from 0.73.9 to 0.73.10. - [Release notes](https://github.com/facebook/metro/releases) - [Changelog](https://github.com/facebook/metro/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/metro/compare/v0.73.9...v0.73.10) --- updated-dependencies: - dependency-name: metro-react-native-babel-preset dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add a custom SVG REPL so so you can paste or type in an svg and render it live! Add a test for a very fancy svg using lots of stuff Add a test for radial gradient * I think testID needs to be on the first item * Change files * auto-nits * Remove fancy svg test * Use callback optimize style * Use useCallback for some callbacks. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: chiuam <67026167+chiuam@users.noreply.github.com> Co-authored-by: UI-Fabric-RN-Bot <uifrnbot@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gulnaz Sayed <30990970+gulnazsayed@users.noreply.github.com> Co-authored-by: Ankita Raj <32593094+ankraj12@users.noreply.github.com> Co-authored-by: Ankita Raj <ankraj@microsoft.com> Co-authored-by: Lawrence Win <lawrence.j.win@gmail.com> Co-authored-by: Ayush Singh <49569838+ayush547@users.noreply.github.com> Co-authored-by: Krystal Kramer <krsiler@microsoft.com> Co-authored-by: Ruriko Araki <ruaraki@microsoft.com> Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> Co-authored-by: Lynn Zhang <78454019+lyzhan7@users.noreply.github.com> Co-authored-by: lenahong <lehon@microsoft.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com> Co-authored-by: Rohan Prasad <rohanpd.work@gmail.com> Co-authored-by: Ayush Singh <ayushsinghs@yahoo.in> Co-authored-by: Adam Gleitman <adam.gleitman@gmail.com> Co-authored-by: Adam Gleitman <adgleitm@microsoft.com> Co-authored-by: Tatiana Kapos <tatianakapos@microsoft.com> Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com> Co-authored-by: Andrew Coates <acoates@microsoft.com> Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Change made in response to feedback from partners.
Up until now, the
onTextandoffTextprops were mutually exclusive with thelabelPositionprop being set to = "before". This is because the Switch position would horizontally shift if the sizes of the on / off texts were uneven, which in most cases are.This commit changes how
onTextandoffTextare rendered by rendering both texts at the same time but hiding the inactive text via height = 0. This allows the on / off text to maintain the same width no matter which text is showing, removing the shifting switch issue.TODO: update documentation
Verification
The videos below show the before / after behaviors on win32. Testing on other platforms would be appreciated.
Pull request checklist
This PR has considered (when applicable):