Minor follow-up optimizations #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulusParssinen
commented
Mar 26, 2024
libs/storage/Tsavorite/cs/src/core/Allocator/MallocFixedPageSize.cs
Outdated
Show resolved
Hide resolved
PaulusParssinen
changed the title
TedHartMS
approved these changes
Mar 26, 2024
badrishc
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the fields properties or by inlining the statements, we allow JIT to consider the values such as record sizes and blittability to be constants.
I missed these in #39
edit: came across
onetwo log2 acceleration oppurtunities I missed in #35 so included it in this PR if that's ok, i think that should be them all.. sry, for expanding the scope of PR