Use Unsafe.SizeOf to calculate object sizes #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
nvm. There apparently was a Tsavorite.test project that is not visible in the normal project solution view. Fixing.. |
jkotas
reviewed
Mar 19, 2024
libs/storage/Tsavorite/cs/src/core/Allocator/BlittableAllocator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 19, 2024
...Tsavorite/cs/src/core/Index/Tsavorite/Implementation/Revivification/RevivificationManager.cs
Show resolved
Hide resolved
Collaborator
Yes, there are too many tests in Tsavorite.test and that degrades the dev experience for Garnet, so those tests are not included in the Garnet solution. They are limited to Tsavorite. Tsavorite CI kicks off if any changes to Tsavorite folder are detected. |
TedHartMS
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes potential GC hole by using BCL's
Unsafe.SizeOf<T>()to calculate sizes for given type parameter more safely 😆.Contributes to #38