Add osversion 18362#581
Conversation
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
| // 2019 (ltsc2019), and Windows 10 (October 2018 Update). | ||
| RS5 = 17763 | ||
|
|
||
| // RS6 (version 1903, codename "Redstone 6") corresponds to Windows Server |
There was a problem hiding this comment.
I'm not sure if this is RS6 or just 19H1 🤔
There was a problem hiding this comment.
There is no RS6/Redstone 6, just 19H1. But I would prefer that we use the public version names for this instead of the code names, since the public names will be less confusing in the long run.
Maybe something like Win10_1903 for the identifier? Not sure how to make this idiomatic in Go (underscores seem rare), but I think we need to include the 10 to minimize confusion between a hypothetical future Windows 10 2003 and Windows 2003.
If we could go back to the others and update them as well, that would be good (can keep the existing RS5, etc. stuff for compatibility with existing callers).
There was a problem hiding this comment.
Thank you for the clarification. For the other suggestions we need consensus from other maintainers which should maybe done in a different PR.
I‘ll leave this PR open for further feedback how to proceed.
There was a problem hiding this comment.
The official (RTM) name of Windows Server 18362 is Windows Server 1903. After RS5, there's no RS6 and the codename naming theme of RSx isn't used anymore.
Since Windows Server 1903 has been released, I suggest to update the comment to use the official release name for 18362, the Windows Server 1903.
See the official announcement: https://cloudblogs.microsoft.com/windowsserver/2019/05/21/windows-server-version-1903-now-generally-available/
The codename (based on Windows Insiders) for 18362 is 19H1, and the next one is 20H1.
There was a problem hiding this comment.
The variety of names is definitely confusing 😓. Will the YYHx naming scheme apply both to Windows Client and Server? (My concern is that if we'll use, e.g. WS1903 and there's a client version of using the same, that it may be equally confusing.
Note that renaming will affect some PR's I have open (moby/moby#39100, moby/libnetwork#2362, #556) - not sure if the constants are already used elsewhere
|
This was added as V19H1 in an unrelated PR. |
4 participants
I have downloaded the ISO files for Windows 10 1903 and Windows Server, version 1903 and found version 18362 in
docker infooutput.It's time to add it to the list of osversions.