Skip to content

Add osversion 18362 #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StefanScherer wants to merge 1 commit into from
Closed

Add osversion 18362 #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions osversion/windowsbuilds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,8 @@ const (
// RS5 (version 1809, codename "Redstone 5") corresponds to Windows Server
// 2019 (ltsc2019), and Windows 10 (October 2018 Update).
RS5 = 17763

// RS6 (version 1903, codename "Redstone 6") corresponds to Windows Server
Copy link
Copy Markdown
Contributor Author

@StefanScherer StefanScherer Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is RS6 or just 19H1 🤔

Copy link
Copy Markdown
Member

@jstarks jstarks Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no RS6/Redstone 6, just 19H1. But I would prefer that we use the public version names for this instead of the code names, since the public names will be less confusing in the long run.

Maybe something like Win10_1903 for the identifier? Not sure how to make this idiomatic in Go (underscores seem rare), but I think we need to include the 10 to minimize confusion between a hypothetical future Windows 10 2003 and Windows 2003.

If we could go back to the others and update them as well, that would be good (can keep the existing RS5, etc. stuff for compatibility with existing callers).

Copy link
Copy Markdown
Contributor Author

@StefanScherer StefanScherer Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. For the other suggestions we need consensus from other maintainers which should maybe done in a different PR.
I‘ll leave this PR open for further feedback how to proceed.

Copy link
Copy Markdown

@eriawan eriawan Jun 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanScherer

The official (RTM) name of Windows Server 18362 is Windows Server 1903. After RS5, there's no RS6 and the codename naming theme of RSx isn't used anymore.

Since Windows Server 1903 has been released, I suggest to update the comment to use the official release name for 18362, the Windows Server 1903.

See the official announcement: https://cloudblogs.microsoft.com/windowsserver/2019/05/21/windows-server-version-1903-now-generally-available/
The codename (based on Windows Insiders) for 18362 is 19H1, and the next one is 20H1.

Copy link
Copy Markdown
Contributor

@thaJeztah thaJeztah Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variety of names is definitely confusing 😓. Will the YYHx naming scheme apply both to Windows Client and Server? (My concern is that if we'll use, e.g. WS1903 and there's a client version of using the same, that it may be equally confusing.

Note that renaming will affect some PR's I have open (moby/moby#39100, moby/libnetwork#2362, #556) - not sure if the constants are already used elsewhere

// 1903 (Semi-Annual Channel (SAC)), and Windows 10 (May 2019 Update).
RS6 = 18362
)