Skip to content

Add support for creating network namespaces inside cloned uvms.#837

Merged
ambarve merged 3 commits intouser/ambarve/lcpr2_clone_uvmfrom
user/ambarve/lcpr3_networking_changes
Jan 27, 2021
Merged

Add support for creating network namespaces inside cloned uvms.#837
ambarve merged 3 commits intouser/ambarve/lcpr2_clone_uvmfrom
user/ambarve/lcpr3_networking_changes

Conversation

@ambarve
Copy link
Copy Markdown
Contributor

@ambarve ambarve commented Jun 13, 2020

This is one of the many small PRs that enable the support for late cloning.
This commit adds the set of functions required for adding network namespace and
network endpoints to cloned UVMs.

Signed-off-by: Amit Barve ambarve@microsoft.com

@ambarve ambarve changed the title Add support for creating network namespaces inside cloned uvms. [Late_clone PR 3/5] Add support for creating network namespaces inside cloned uvms. Jun 13, 2020
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch 3 times, most recently from d71a09d to 5ba0510 Compare June 15, 2020 20:20
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch 2 times, most recently from d882b1f to b30b021 Compare June 15, 2020 20:41
@ambarve ambarve marked this pull request as ready for review June 15, 2020 20:45
@ambarve ambarve requested a review from a team as a code owner June 15, 2020 20:45
@ambarve ambarve changed the title [Late_clone PR 3/5] Add support for creating network namespaces inside cloned uvms. Add support for creating network namespaces inside cloned uvms. Jun 17, 2020
Comment thread cmd/containerd-shim-runhcs-v1/pod.go
@kevpar
Copy link
Copy Markdown
Member

kevpar commented Jul 15, 2020

Please rebase these commits into a more curated set for review and check-in.

Comment thread internal/uvm/network.go Outdated
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from eccdda2 to 5b4bfbd Compare August 18, 2020 22:29
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 14f71f8 to 9fb2388 Compare August 18, 2020 22:29
Comment thread internal/uvm/network.go Outdated
Comment thread internal/uvm/network.go Outdated
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from 5b4bfbd to ea05479 Compare September 17, 2020 04:50
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 9fb2388 to 3932868 Compare September 17, 2020 05:56
Comment thread internal/hcsoci/network.go Outdated
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from ea05479 to 9ab44b4 Compare September 18, 2020 22:08
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 3932868 to 258739d Compare September 18, 2020 22:17
Copy link
Copy Markdown
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dcantah
Copy link
Copy Markdown
Contributor

dcantah commented Oct 6, 2020

@katiewasnothere Can you take a quick peek at this? Would like another sign off

@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from 9ab44b4 to 4fc5e7e Compare October 22, 2020 05:57
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 258739d to fff6c8f Compare October 22, 2020 05:57
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from 4fc5e7e to 562bfc4 Compare November 16, 2020 20:35
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from fff6c8f to 72da34c Compare November 16, 2020 20:36
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from 562bfc4 to 3076f21 Compare December 22, 2020 09:37
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from 72da34c to e6b428b Compare December 22, 2020 09:37
This is one of the many small PRs that enable the support for late cloning.
This commit adds the set of functions required for adding network namespace and
network endpoints to cloned UVMs.

Signed-off-by: Amit Barve <ambarve@microsoft.com>
@ambarve ambarve force-pushed the user/ambarve/lcpr2_clone_uvm branch from 3076f21 to aa48bc3 Compare December 23, 2020 22:08
@ambarve ambarve force-pushed the user/ambarve/lcpr3_networking_changes branch from e6b428b to e91e7f2 Compare December 23, 2020 22:08
Copy link
Copy Markdown
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ambarve and others added 2 commits January 27, 2021 14:20
This is one of the many small PRs that enable the support for late
cloning.This commit adds the set of functions that expose the late cloning
functionality from hcsshim and adds new annotations for clients to use
the late cloning feature.

Signed-off-by: Amit Barve <ambarve@microsoft.com>
…aner

Add support for creating late clones via hcsshim
@ambarve ambarve merged commit 3814930 into user/ambarve/lcpr2_clone_uvm Jan 27, 2021
@helsaawy helsaawy deleted the user/ambarve/lcpr3_networking_changes branch May 24, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants