This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Use configs of previous LogEntry for refresh action #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@imback82 What if a user wants to change the configs - with full refresh mode? Should we consider that case also? |
Contributor
Let's not support it for now (the user can create a new index with a different number of buckets if needed - since refreshing full is like creating a new one). We can introduce a "overwrite" config later if needed. |
imback82
reviewed
Oct 13, 2020
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
Few minor comments, but the PR looks fine to me.
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/actions/RefreshActionBase.scala
Outdated
Show resolved
Hide resolved
imback82
reviewed
Oct 13, 2020
src/main/scala/com/microsoft/hyperspace/actions/CreateActionBase.scala
Outdated
Show resolved
Hide resolved
imback82
approved these changes
Oct 13, 2020
imback82
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
Fixes #196
What changes were proposed in this pull request?
Instead of using the current spark.config, this PR gets numBuckets and lineage column config from previous index entry at refresh and use it for refresh.
Does this PR introduce any user-facing change?
Fixes a buggy behavior.
How was this patch tested?
Unit test