Skip to content
This repository was archived by the owner on Mar 15, 2025. It is now read-only.

Add Azure Storage Policies#375

Merged
krnese merged 23 commits intosecure-by-defaultfrom
marvinbuss/storage_policy
Mar 3, 2023
Merged

Add Azure Storage Policies#375
krnese merged 23 commits intosecure-by-defaultfrom
marvinbuss/storage_policy

Conversation

@marvinbuss
Copy link
Contributor

Summary of the Pull Request

  • Add Azure Storage Policies based on documented gaps. Please review internal doc for more details.

PR Checklist

Validation Steps Performed

@marvinbuss marvinbuss added the enhancement New feature or request label Feb 28, 2023
@marvinbuss marvinbuss requested review from a team and krnese February 28, 2023 09:08
@marvinbuss marvinbuss self-assigned this Feb 28, 2023
},
{
"properties": {
"displayName": "Encryption for storage services should be enforced for Storage Accounts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this policy work in conjunction with /providers/Microsoft.Authorization/policyDefinitions/b5ec538c-daa0-4006-8596-35468b9148e8 (encryption scopes should use CMK) which we are already including?

Copy link
Contributor Author

@marvinbuss marvinbuss Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows using different keys and key types for different scopes within a storage account. You could otherwise potentially rely on a CMK as a default option but the apply an encryption scope that uses a Microsoft-managed key to container001 and hence not rely on the CMK encryption.

},
{
"properties": {
"displayName": "Public blob access should be restricted for Storage Accounts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems redundant to /providers/Microsoft.Authorization/policyDefinitions/b2982f36-99f2-4db5-8eff-283140c09693 (Storage accounts should disable public network access) which we are including, no?

Copy link
Contributor Author

@marvinbuss marvinbuss Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The policy you mentioned cannot be used in a data context when relying on Databricks or Synapse. For these services, we have to rely on the Resource access rules feature, which is why I included all the other necessary policies to keep the environment as secure as possible.
I can remove it if you think it is redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to remove all the related policy rules for now?

@marvinbuss marvinbuss requested a review from krnese February 28, 2023 10:16
@marvinbuss marvinbuss requested review from krnese and removed request for krnese February 28, 2023 21:58
@marvinbuss
Copy link
Contributor Author

@krnese
image

@krnese krnese merged commit 57e8a4e into secure-by-default Mar 3, 2023
@krnese krnese deleted the marvinbuss/storage_policy branch March 3, 2023 18:04
krnese added a commit that referenced this pull request Mar 3, 2023
* wave #1

* adding AKS

* added defender options

* adding mySql and other minor updates

* update

* backup completeness

* update + event grid

* adding Azure Data Explorer

* minor update

* adding rbac

* formatting

* adding ARM template for compliant services

* v2 refresh

* optimizing dependency

* adding policies

* dns update

* Update hubspoke-connectivity.json

* Update industryArmV2.json

* Update hubspoke-connectivity.json

* Update fsiPortalV2.json

* Update industryArmV2.json

* adding EH for data export

* Compliant network policySet

* prevent ssh and rdp from internet to network

* erDiag

* updated data export with description

* adding sub for ingress and egress

* adding assignments

* name lenght

* updated KV and adding cosmosDb

* more data stuff

* removing 'db'

* compliant events

* aks + nw

* Update Cognitive Services Policies (#370)

Co-authored-by: Kristian Nese <kristian.nese@microsoft.com>

* nw part 1

* network orchestration

* sql policySet

* adding sql, service bus, and postgre sql

* adding sql assignment + storage def and assignment

* updating condition

* lenght

* correcting params

* Network Policies (#374)

* Network Policies

* Removing duplicate assignments

---------

Co-authored-by: Kristian Nese <kristian.nese@microsoft.com>

* adding synapse

* update assignment name

* param mapping

* compliant corp lz

* update condition

* fixing url

* converge on private DNS across verticals

* compliant corp lz and modification to each vertical

* updated compliant services

* adding AVD

* Centralized logging initiative

* added diag to storage account

* naming convention for storage

* default identity sub behavior

* Add Azure Storage Policies (#375)

* Add Azure Storage Policies

* Fix minor bug

* Update type

* Add policy for CORS rules

* Add policy for CMK for encryption scopes

* Remove policy for encryption scope

* Update display name

* Add list of allowed values for policy definition

* Update policy for encryption

* Add policy assignments

* Removed policy for cross tenant PEs

* Add missing parameters

* Update mg name

* update sequencing

---------

Co-authored-by: Marvin Buss <34542414+marvinbuss@users.noreply.github.com>
Co-authored-by: Uday Pandya <14359777+uday31in@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants