This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add simple display encoders for CloudJob, TargetStatus, and Histogram #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Granade <chgranad@microsoft.com>
cgranade
reviewed
Jun 8, 2020
rmshaffer
changed the title
theRoughCode
reviewed
Jun 8, 2020
anpaz
approved these changes
Jun 9, 2020
Member
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
This looks great. Couple of minor changes, once addressed lgtm.
1 task
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Base automatically changed from
rmshaffer/azure-entrypoint
to
feature/azure-client
June 12, 2020 19:31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds display encoders for
CloudJob,TargetStatus, andHistogramobjects, which ensures both that they are displayed properly in Jupyter clients and that a reasonable object is returned when invoking from Python.Fixes AB#15606, fixes AB#15312, fixes AB#15310.