This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Support several parameters for IQ# Azure Quantum job execution #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Granade <chgranad@microsoft.com>
rmshaffer
changed the title
rmshaffer
changed the title
This was referenced Jun 10, 2020
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Co-authored-by: Chris Granade <chgranad@microsoft.com>
cgranade
approved these changes
Jun 12, 2020
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
This all makes sense, and looks like a nice improvement! I just had one question about future integration with the %config, but that was about it.
| /// The timeout determines how long the IQ# kernel will wait for the job to complete; | ||
| /// the Azure Quantum job itself will continue to execute until it is completed. | ||
| /// </remarks> | ||
| public int ExecutionTimeout { get; set; } = DefaultExecutionTimeoutInSeconds; |
Contributor
There was a problem hiding this comment.
Is the plan for these two properties to connect up to %config, or will there be another way to set them?
Contributor
Author
There was a problem hiding this comment.
With these changes, the two properties can be set via timeout and poll parameters to the %azure.execute magic command. It’s worth discussing whether they should be on %config instead, but since they only apply to %azure.execute it seemed to make sense to put them here for now.
Base automatically changed from
rmshaffer/azure-encoders
to
feature/azure-client
June 12, 2020 19:47
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
jobName,shots,timeout, andpollparameters when submitting Azure Quantum jobs from IQ#.It also unifies the submission and execution code paths, which had some duplication previously and otherwise would have required more duplication to add these parameters.
To complete before merging:
feature/azure-clientafter Auto-generate entry point for Azure job submission #156 and Add simple display encoders for CloudJob, TargetStatus, and Histogram #160 are merged.