This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Remove assertion that compilation had no warnings in engine tests #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/qsharp-compiler#791 adds deprecation warnings when parentheses are used for
for,usingandborrowingstatements. IQ# has test snippets that trigger these warnings, for example:iqsharp/src/Tests/SNIPPETS.cs
Lines 319 to 321 in afeb47a
The IQ# tests also assert that no warnings were generated, which caused the end-to-end build to fail. Since the warnings were designed to not introduce any breaking changes yet, it would be nice if IQ# tests didn't rely on there being no warnings.
The other option is to update the tests to remove the deprecated parentheses and avoid the warnings - let me know which option seems better.
Cc: @bettinaheim