Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Dec 23, 2020

microsoft/qsharp-compiler#791 adds deprecation warnings when parentheses are used for for, using and borrowing statements. IQ# has test snippets that trigger these warnings, for example:

for(i in n-1..-1..0) {
set m w/= i <- array[n - 1 - i];
}

The IQ# tests also assert that no warnings were generated, which caused the end-to-end build to fail. Since the warnings were designed to not introduce any breaking changes yet, it would be nice if IQ# tests didn't rely on there being no warnings.

The other option is to update the tests to remove the deprecated parentheses and avoid the warnings - let me know which option seems better.

Cc: @bettinaheim

@bamarsha
Copy link
Contributor Author

bamarsha commented Jan 8, 2021

@rmshaffer It looks like this PR and #386 are blocked by a component governance alert for y18n 4.0.0.

@cgranade
Copy link
Contributor

With the alert for y18n being resolved by #388, I think this should now be ready to merge in. Thanks for fixing this, @SamarSha!

@cgranade cgranade merged commit 1610c48 into main Jan 13, 2021
@bamarsha bamarsha deleted the samarsha/statement-parens branch January 13, 2021 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants