This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Send kernel_info_reply from shell server #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ScottCarda-MS
previously approved these changes
Jan 12, 2021
guenp
previously approved these changes
Jan 12, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
bamarsha
approved these changes
Jan 13, 2021
ScottCarda-MS
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that kernel_info_reply messages are sent as early as possible by sending them from the shell server directly instead of waiting for the engine constructor to finish. See microsoft/jupyter-core#69 for details.