Centralize ID generation to avoid conflicts across multiple library instances #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Keyborg.tsfile currently uses a file-scoped_lastIdcounter to generate unique IDs for Keyborg and KeyborgCore instances. This approach can lead to ID conflicts when multiple versions or instances of the library are loaded in the same environment, potentially causing unexpected behavior or collisions.Solution
This PR centralizes and improves the ID generation logic by:
_lastIdvariable that could cause conflicts across instancesgetUniqueIdfunction: A new utility function that takes a prefix (kfor Keyborg,cfor KeyborgCore) and returns unique IDs using timestamp + random counter_lastIdreferences with calls to the centralized functionChanges Made
let _lastId = 0;file-scoped countergetUniqueId(prefix: string): stringfunction that generates IDs in format<prefix>-<timestamp>-<counter>"c" + ++_lastId→getUniqueId("c")"k" + ++_lastId→getUniqueId("k")Benefits
ID Format Change
Before:
k1,k2,c1,c2, etc.After:
k-1748029187912-4694,c-1748029187913-5031, etc.The new format ensures uniqueness while maintaining the prefix-based identification system.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.