Skip to content

Centralize ID generation to avoid conflicts across multiple library instances #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Centralize ID generation to avoid conflicts across multiple library instances #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44505d5
Initial plan for issue
Copilot May 23, 2025
d7e760a
Centralize ID generation to avoid conflicts across instances
Copilot May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/Keyborg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,17 @@ interface WindowWithKeyborg extends Window {
const _dismissTimeout = 500; // When a key from dismissKeys is pressed and the focus is not moved
// during _dismissTimeout time, dismiss the keyboard navigation mode.

let _lastId = 0;
/**
* Generates a unique ID with the specified prefix
* @param prefix - The prefix for the ID ('k' for Keyborg, 'c' for KeyborgCore)
* @returns A unique ID in the format `<prefix>-<number>`
*/
function getUniqueId(prefix: string): string {
// Use timestamp + counter for uniqueness across instances
const timestamp = Date.now();
const counter = Math.floor(Math.random() * 10000);
return `${prefix}-${timestamp}-${counter}`;
}

export interface KeyborgProps {
// Keys to be used to trigger keyboard navigation mode. By default, any key will trigger
Expand All @@ -48,7 +58,7 @@ class KeyborgCore implements Disposable {
private _isNavigatingWithKeyboard_DO_NOT_USE = false;

constructor(win: WindowWithKeyborg, props?: KeyborgProps) {
this.id = "c" + ++_lastId;
this.id = getUniqueId("c");
this._win = win;
const doc = win.document;

Expand Down Expand Up @@ -291,7 +301,7 @@ export class Keyborg {
}

private constructor(win: WindowWithKeyborg, props?: KeyborgProps) {
this._id = "k" + ++_lastId;
this._id = getUniqueId("k");
this._win = win;

const current = win.__keyborg;
Expand Down