Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…b.com/microsoft/mssql-python into bewithgaurav/refactor_get_driver_path
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Alpine Linux support to the mssql-python library by resolving circular import issues that occurred during module initialization on Alpine's musl-based system. The key change moves driver path resolution from Python to C++ to avoid importing Python helpers during critical initialization phases.
- Implemented C++ driver path resolution to replace Python-based approach
- Added Alpine Linux distribution detection and driver loading support
- Included comprehensive Alpine ARM64 testing pipeline with containerized environment
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| mssql_python/pybind/ddbc_bindings.cpp | Replaced Python-based driver path resolution with pure C++ implementation including Alpine detection |
| mssql_python/helpers.py | Removed Python helper functions for driver path resolution and Linux distro detection |
| tests/test_000_dependencies.py | Updated tests to use new C++ driver path function and added Alpine detection logic |
| eng/pipelines/pr-validation-pipeline.yml | Added Alpine ARM64 testing pipeline and renamed existing Linux jobs for clarity |
github-actions
bot
added
pr-size: large
github-actions
bot
added
pr-size: large
github-actions
bot
added
pr-size: large
github-actions
bot
added
pr-size: large
github-actions
bot
added
pr-size: large
sumitmsft
approved these changes
Aug 6, 2025
gargsaumya
approved these changes
Aug 6, 2025
github-actions
bot
added
pr-size: large
jahnvi480
approved these changes
Aug 6, 2025
github-actions
bot
added
pr-size: large
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work Item / Issue Reference
Summary
Introducing Alpine Support