Conversation
edgchen1
reviewed
Apr 22, 2025
onnxruntime/core/providers/coreml/builders/impl/base_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/squeeze_op_builder.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Apr 22, 2025
onnxruntime/core/providers/coreml/builders/impl/base_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/pad_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/squeeze_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Apr 24, 2025
… suggestions for comments
edgchen1
reviewed
Apr 29, 2025
onnxruntime/core/providers/coreml/builders/impl/binary_op_builder.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Apr 29, 2025
skottmckay
reviewed
Apr 29, 2025
onnxruntime/core/providers/coreml/builders/impl/binary_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
approved these changes
Apr 30, 2025
ankitm3k
pushed a commit
to intel/onnxruntime
that referenced
this pull request
May 12, 2025
### Description Add int64 as a supported datatype for moving nodes to the CoreML EP. We already convert constants automatically from int64 to int32 for CoreML by calling narrow. Adding the conversion for outputs as well. ### Motivation and Context - More nodes supported on CoreML ### Note on the Unsqueeze op According to microsoft#22975 there is a bug with the Unsqueeze op with scalar inputs on x86. I was running into a bug for unsqueezes that unsqueezed a scalar input to a tensor of shape [1] since CoreML doesn't support scalar values for MLProgram. I adapted the HandleX86ArchUnsqueeze method but alternatively, can replace with an identity operator or add some additional checks. I went with adapting the HandleX86ArchUnsqueeze method since it seemed like the fastest solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add int64 as a supported datatype for moving nodes to the CoreML EP.
We already convert constants automatically from int64 to int32 for CoreML by calling narrow.
Adding the conversion for outputs as well.
Motivation and Context
Note on the Unsqueeze op
According to #22975 there is a bug with the Unsqueeze op with scalar inputs on x86.
I was running into a bug for unsqueezes that unsqueezed a scalar input to a tensor of shape [1] since CoreML doesn't support scalar values for MLProgram. I adapted the HandleX86ArchUnsqueeze method but alternatively, can replace with an identity operator or add some additional checks. I went with adapting the HandleX86ArchUnsqueeze method since it seemed like the fastest solution.