move ParallelLinuxPerfScriptStackSource to TraceEvent, fixes #1103#1112
Conversation
…cesary public APIs
|
Please excuse me, but for some reason the build succeded on my machine while it should have failed. It turns out that .NET Standard 1.6 is missing some very basic APIs and types like
@brianrob I've added a rule to the project file to not compile these types for .NET Standard 1.6. I hope that it's OK. |
|
@adamsitnik I think it will be fine to not compile these types for the netstandard1.6 target. I believe this is around for users of older runtimes (e.g. older desktop and .NET Core 1.x). It's actually probably safe to remove the netstandard1.6 target entirely, but we don't need to do that now. |
brianrob
left a comment
There was a problem hiding this comment.
A couple of small requests, but otherwise, looks good.
|
@brianrob thanks for the review! I've changed the namespaces (which was a good idea BTW) |
cc @brianrob