Remove PDB generation for .NET Core assemblies using CrossGen #2202
Conversation
…r .NET Core assemblies Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
src/PerfView/App.cs
Outdated
| /// </summary> | ||
| public static SymbolReader GetSymbolReader(string etlFilePath = null, SymbolReaderOptions symbolFlags = SymbolReaderOptions.None) | ||
| { | ||
| // Apply the DisableNGenPdbGeneration option if it's set in the command line |
There was a problem hiding this comment.
Looking a bit further at the code, there is already a /NoNGenPdbs flag that disables NGEN PDB generation. Please undo this entire change.
Instead, please change this PR to remove .NET Core PDB generation that uses crossgen. This is implemented in SymbolReader.cs. The call to HandleNetCorePdbs is what does this. The entire function should be removed. You can also remove GetCrossGenExePath.
There was a problem hiding this comment.
I've updated the PR to remove the CrossGen PDB generation code as requested. I've removed the HandleNetCorePdbs and GetCrossGenExePath methods from SymbolReader.cs and updated the fallback handling when a CLR directory is not found. I've also reverted the DisableNGenPdbGeneration flag changes since the existing /NoNGenPdbs flag already handles this functionality. Changes are in commit 9d0f742.
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
brianrob
changed the title
Removes PDB creation via usage of the crossgen.exe tool. For .NET Core PDBs are created on package publish, and most machines won't have crossgen or crossgen2 available.