Skip to content

Reapply "Revert "test: make trace-viewer tests e2e (#39174)"#39209

Merged
Skn0tt merged 3 commits intomicrosoft:mainfrom
Skn0tt:e2e-ffox
Feb 10, 2026
Merged

Reapply "Revert "test: make trace-viewer tests e2e (#39174)"#39209
Skn0tt merged 3 commits intomicrosoft:mainfrom
Skn0tt:e2e-ffox

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Feb 10, 2026

relands, but without the bug reported in #39202.

@Skn0tt Skn0tt requested a review from dgozman February 10, 2026 10:00
const cp = childProcess({ command });
await cp.waitForOutput('Listening on');
const browser = await playwright.chromium.launch({
executablePath: process.env.CRPATH, // without this, setting FFPATH makes us launch Firefox with Chromium args
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the change

@github-actions
Copy link
Contributor

Test results for "tests 1"

6 failed
❌ [playwright-test] › reporter-html.spec.ts:1078 › created › should use file-browser friendly extensions for buffer attachments based on contentType @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:577 › should not mark page.close as failed when page.click fails @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:98 › should not retry serial mode suites with missing expectation errors @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:371 › should not preserve selection across test runs @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:669 › update-source-method › should overwrite source when specified in the config @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:345 › should update multiple files @windows-latest-node20

3 flaky ⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38 › should upload a folder `@webkit-ubuntu-22.04-node20`

38550 passed, 843 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

12 failed
❌ [chrome] › mcp/cli-session.spec.ts:152 › workspace isolation - sessions in different workspaces are isolated @mcp-windows-latest
❌ [chrome] › mcp/video.spec.ts:43 › should work with { saveVideo } (isolated) @mcp-macos-15
❌ [chromium] › mcp/cli-devtools.spec.ts:94 › video-start-stop @mcp-macos-15
❌ [chromium] › mcp/cli-save-as.spec.ts:19 › screenshot @mcp-macos-15
❌ [chromium] › mcp/cli-save-as.spec.ts:26 › screenshot @mcp-macos-15
❌ [chromium] › mcp/cli-save-as.spec.ts:41 › screenshot --filename @mcp-macos-15
❌ [chromium] › mcp/core.spec.ts:158 › browser_resize @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:23 › should work with --save-video (persistent) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:43 › should work with { saveVideo } (persistent) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (persistent) @mcp-macos-15

4754 passed, 135 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit f7234ae into microsoft:main Feb 10, 2026
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants