test(bidi): set channel option in showTraceViewer() fixture#39222
Merged
Skn0tt merged 4 commits intomicrosoft:mainfrom Feb 12, 2026
Merged
test(bidi): set channel option in showTraceViewer() fixture#39222Skn0tt merged 4 commits intomicrosoft:mainfrom
Skn0tt merged 4 commits intomicrosoft:mainfrom
Conversation
Skn0tt
reviewed
Feb 11, 2026
Co-authored-by: Simon Knott <info@simonknott.de> Signed-off-by: Holger Benl <hbenl@evandor.de>
Skn0tt
approved these changes
Feb 11, 2026
This comment has been minimized.
This comment has been minimized.
Member
|
Hmm, looks like we can't fully ignore |
Skn0tt
reviewed
Feb 11, 2026
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Simon Knott <info@simonknott.de> Signed-off-by: Holger Benl <hbenl@evandor.de>
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"4 flaky38521 passed, 843 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 4791 passed, 135 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #39209 the trace-viewer tests are failing in Firefox Bidi test runs because the defaultLaunchOptions contain
channel: 'moz-firefox-nightly-library'and thereforeplaywright.chromium.launch()throws.