Skip to content

test(bidi): set channel option in showTraceViewer() fixture#39222

Merged
Skn0tt merged 4 commits intomicrosoft:mainfrom
hbenl:trace-viewer-channel
Feb 12, 2026
Merged

test(bidi): set channel option in showTraceViewer() fixture#39222
Skn0tt merged 4 commits intomicrosoft:mainfrom
hbenl:trace-viewer-channel

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Feb 11, 2026

After #39209 the trace-viewer tests are failing in Firefox Bidi test runs because the defaultLaunchOptions contain channel: 'moz-firefox-nightly-library' and therefore playwright.chromium.launch() throws.

@hbenl hbenl requested a review from Skn0tt February 11, 2026 14:34
Co-authored-by: Simon Knott <info@simonknott.de>
Signed-off-by: Holger Benl <hbenl@evandor.de>
@github-actions

This comment has been minimized.

@Skn0tt
Copy link
Member

Skn0tt commented Feb 11, 2026

Hmm, looks like we can't fully ignore defaultLaunchOptions. No luck with this patch of mine so far!

@github-actions

This comment has been minimized.

hbenl and others added 2 commits February 12, 2026 09:32
Co-authored-by: Simon Knott <info@simonknott.de>
Signed-off-by: Holger Benl <hbenl@evandor.de>
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-set-input-files.spec.ts:38 › should upload a folder `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:384 › should reveal errors in the sourcetab `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:700 › should indicate current test status `@macos-latest-node20`

38521 passed, 843 skipped


Merge workflow run.

@Skn0tt Skn0tt merged commit 8946b03 into microsoft:main Feb 12, 2026
32 of 33 checks passed
@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/tracing.spec.ts:21 › check that trace is saved with --save-trace @mcp-windows-latest

4791 passed, 135 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants