Skip to content

test(bidi): set channel option in showTraceViewer() fixture #39222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 4 commits into from
Feb 12, 2026
Merged

test(bidi): set channel option in showTraceViewer() fixture #39222

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a8d4cd
test(bidi): set channel option in showTraceViewer() fixture
hbenl Feb 11, 2026
cb1cb44
Update tests/config/traceViewerFixtures.ts
hbenl Feb 11, 2026
c78ca76
Update tests/config/traceViewerFixtures.ts
hbenl Feb 12, 2026
fc3e64e
fix errors
hbenl Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/config/traceViewerFixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class TraceViewerPage {
}

export const traceViewerFixtures: Fixtures<TraceViewerFixtures, {}, BaseTestFixtures, BaseWorkerFixtures> = {
showTraceViewer: async ({ playwright, childProcess }, use) => {
showTraceViewer: async ({ playwright, childProcess, browserName }, use) => {
const browsers: Browser[] = [];
await use(async (trace: string | undefined, { host, port, stdin } = {}) => {
const command = [
Expand All @@ -171,6 +171,7 @@ export const traceViewerFixtures: Fixtures<TraceViewerFixtures, {}, BaseTestFixt
const cp = childProcess({ command });
await cp.waitForOutput('Listening on');
const browser = await playwright.chromium.launch({
...(browserName === 'chromium' ? {} : { channel: 'chromium' }),
executablePath: process.env.CRPATH, // without this, setting FFPATH makes us launch Firefox with Chromium args
});
browsers.push(browser);
Expand Down
Loading