feat(api): add Response.httpVersion() method#39309
Closed
smckee-r7 wants to merge 1 commit intomicrosoft:mainfrom
Closed
feat(api): add Response.httpVersion() method#39309smckee-r7 wants to merge 1 commit intomicrosoft:mainfrom
smckee-r7 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
|
|
||
| _setHttpVersion(httpVersion: string) { | ||
| this._httpVersion = httpVersion; | ||
| this._httpVersionPromise.resolve(httpVersion); |
Member
There was a problem hiding this comment.
This is called quite late on webkit.
Contributor
Author
|
@pavelfeldman Thanks for the feedback. I've updated the code, based on your comments above. I've removed direct await in the harTracer event handlers and followed the same pattern used for other promise based response methods (smckee-r7@c4fd245). This should now be consistent with how Can I open a new PR with these changes, or can this be reopened perhaps? If you still see issues with the changes, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Response.httpVersion()to get the http version of a given responseIssue: #39310