feat(api): add Response.httpVersion() method by smckee-r7 · Pull Request #39434 · microsoft/playwright

smckee-r7 · 2026-02-26T14:32:16Z

Adds Response.httpVersion() to get the http version of a given response.
Issue: #39310

Previous PR #39309 was closed out with some comments. I've addressed the comments and opened a this new PR. This feature would be extremely useful to reduce bloat/boilerplate for our test suite.

yury-s

The PR still has too many issues and lacking any tests. Unfortunately, I don't see it converging.

yury-s · 2026-02-26T18:56:27Z

packages/playwright-core/src/server/network.ts

+    if (httpVersion === 'h2')
      return 'HTTP/2.0';
-    return this._httpVersion;
+    if (httpVersion === 'h3')


this does not improve things and just adds confusion, don't change it

yury-s · 2026-02-26T18:59:08Z

packages/playwright-core/src/server/network.ts

    this._getResponseBodyCallback = getResponseBodyCallback;
    this._request._setResponse(this);
-    this._httpVersion = httpVersion;
+    if (httpVersion)


only one client has it ready right away, make it call the new setter and remove the param

yury-s · 2026-02-26T18:59:44Z

packages/playwright-core/src/server/har/harTracer.ts

  }

-  private _onResponse(response: network.Response) {
+  private async _onResponse(response: network.Response) {


we don't want async event handlers

yury-s · 2026-02-26T19:01:02Z

packages/playwright-core/src/client/network.ts

+  async httpVersion(): Promise<string> {
+    return this._wrapApiCall(async () => {
+      return (await this._channel.httpVersion()).value;
+    }, { internal: true });


why do you have this here while it's already defined in the protocol yaml?

Your 100% right, my bad, I naively dived into this PR before understanding enough and misunderstood the architecture. Once I found the protocol.yml I added the definition there, but forgot to revert this change

smckee-r7 · 2026-02-27T10:54:55Z

The PR still has too many issues and lacking any tests. Unfortunately, I don't see it converging.

I've hopefully resolved your comments and added a basic test. I'm willing get this to a place you guys are happy with but if that's never going to happen, feel free to close the PR. However, not having this feature would be a shame since the only way to assert the httpVersion using HAR recording is currently awkward/heavy

dgozman · 2026-03-02T15:10:57Z

packages/playwright-core/src/server/webkit/wkPage.ts

      });
-      if (event.metrics?.protocol)
-        response._setHttpVersion(event.metrics.protocol);
+      response._setHttpVersion(event.metrics?.protocol ?? null);


We should call this from _onLoadingFailed as well, similar to calling _securityDetailsFinished().

dgozman · 2026-03-02T15:12:11Z

packages/playwright-core/src/server/firefox/ffNetworkManager.ts

    }
-    if (event.protocolVersion)
-      response._setHttpVersion(event.protocolVersion);
+    response._setHttpVersion(event.protocolVersion ?? null);


Call this from _onRequestFailed as well.

dgozman · 2026-03-02T15:13:21Z

packages/playwright-core/src/server/har/harTracer.ts

-    const httpVersion = response.httpVersion();
-    harEntry.request.httpVersion = httpVersion;
-    harEntry.response.httpVersion = httpVersion;
+    this._addBarrier(page || request.serviceWorker(), response.httpVersion().then(httpVersion => {


We don't need two barriers for http version. Let's only have a single one in _onResponse() that sets both request and response http versions.

dgozman · 2026-03-02T15:15:07Z

tests/page/page-network-response.spec.ts

 import { expect, test as it } from './pageTest';
+import { TestServer } from '../config/testserver';
+
+const { createHttp2Server } = require('../../packages/playwright-core/lib/utils');


New imports looks unused.

dgozman · 2026-03-02T15:17:28Z

tests/page/page-network-response.spec.ts

  expect(request.existingResponse()).toBe(response);
 });
+
+it('should return http version', async ({ page, server }) => {


Let's add a test for a failing request - httpVersion() should not hang in this case. Consult Page.Events.RequestFailed from page-event-network.spec.ts to see how to trigger a failing request.

Based on that test you mentioned, it shows that the Response object should be null if the request fails. This PR only exposes the httpVersion method on the response. Not sure how I'd test that exactly since the Response should be null.

I did briefly consider adding a httpVersion method to the Request but it didn't feel like it made sense. Since as far as I can tell, it's not available until a response payload is received anyway.

Good point, you are right!

github-actions · 2026-03-03T15:18:03Z

Test results for "tests 1"

7 failed
❌ [firefox-library] › library/har.spec.ts:883 › should not hang on slow chunked response @firefox-ubuntu-22.04-node20
❌ [webkit-library] › library/har.spec.ts:119 › should include redirectURL @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/har.spec.ts:615 › should have connection details for redirects @webkit-ubuntu-22.04-node20
❌ [webkit-library] › library/har.spec.ts:883 › should not hang on slow chunked response @webkit-ubuntu-22.04-node20
❌ [playwright-test] › playwright.spec.ts:877 › page.pause() should disable test timeout @macos-latest-node20
❌ [playwright-test] › reporter.spec.ts:251 › merged › should not have internal error when steps are finished after timeout @macos-latest-node20
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:371 › should not preserve selection across test runs @macos-latest-node20

5 flaky

⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1216 › should display language-specific locators `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1216 › should display language-specific locators `@webkit-ubuntu-22.04-node20`

38690 passed, 841 skipped

Merge workflow run.

github-actions · 2026-03-03T15:20:16Z

Test results for "MCP"

2 failed
❌ [chrome] › mcp/roots.spec.ts:47 › check that trace is saved in workspace @mcp-windows-latest
❌ [chromium] › mcp/http.spec.ts:210 › http transport browser lifecycle (persistent) @mcp-macos-15

5209 passed, 171 skipped

Merge workflow run.

dgozman

Looks great, thank you for the PR!

dgozman · 2026-03-03T14:39:42Z

tests/page/page-network-response.spec.ts

  expect(request.existingResponse()).toBe(response);
 });
+
+it('should return http version', async ({ page, server }) => {


Good point, you are right!

For hanging requests in Firefox/WebKit, the HTTP version promise never resolves, causing HAR flush to hang indefinitely. Remove from barrier promises while keeping the non-blocking update. Fixes issues introduced in microsoft#39434

smckee-r7 added 2 commits February 18, 2026 11:55

feat(api): add Response.httpVersion() method

d31ae50

serialize httpVersion(), remove await pattern in event handlers

c4fd245

smckee-r7 mentioned this pull request Feb 26, 2026

[Feature]: Response http version #39310

Open

yury-s reviewed Feb 26, 2026

View reviewed changes

address comments

0b1894d

dgozman reviewed Mar 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

PR comments

6c37146

smckee-r7 requested review from dgozman and yury-s March 3, 2026 12:43

dgozman approved these changes Mar 3, 2026

View reviewed changes

dgozman merged commit fd3cd92 into microsoft:main Mar 3, 2026
32 of 38 checks passed

This was referenced Mar 3, 2026

[Ports]: Backport client side changes for 1.59 microsoft/playwright-python#3027

Open

[Ports]: Backport client side changes for 1.59 microsoft/playwright-java#1884

Open

[Ports]: Backport client side changes for 1.59 microsoft/playwright-dotnet#3274

Open

smckee-r7 mentioned this pull request Mar 4, 2026

fix(har): don't wait for HTTP version in HAR tracer #39506

Closed

Conversation

smckee-r7 commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yury-s left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smckee-r7 commented Feb 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smckee-r7 Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Mar 3, 2026

Test results for "tests 1"

Uh oh!

github-actions bot commented Mar 3, 2026

Test results for "MCP"

Uh oh!

dgozman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

smckee-r7 commented Feb 26, 2026 •

edited

Loading

smckee-r7 Mar 3, 2026 •

edited

Loading