feat(api): add annotate option for video and screencast#39783
Merged
pavelfeldman merged 2 commits intomicrosoft:mainfrom Mar 20, 2026
Merged
feat(api): add annotate option for video and screencast#39783pavelfeldman merged 2 commits intomicrosoft:mainfrom
pavelfeldman merged 2 commits intomicrosoft:mainfrom
Conversation
dgozman
approved these changes
Mar 20, 2026
| ### option: Screencast.start.annotate | ||
| * since: v1.59 | ||
| - `annotate` ?<[Object]> | ||
| - `delay` ?<[int]> How long each annotation is displayed in milliseconds. Defaults to `500`. |
Contributor
There was a problem hiding this comment.
Let's explain that all input actions are delayed by this amount - this came as a surprise while reading the code.
Member
Author
There was a problem hiding this comment.
I'll follow up, want to add a test step there.
Co-authored-by: Dmitry Gozman <dgozman@gmail.com> Signed-off-by: Pavel Feldman <pavel.feldman@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
reviewed
Mar 20, 2026
| stopForTracing(listener: ScreencastListener) { | ||
| this.stopScreencast(listener).catch(e => debugLogger.log('error', e)); | ||
| this._frameThrottler.setThrottlingEnabled(false); | ||
| this.dispose(); |
Member
There was a problem hiding this comment.
this method can be called multiple times
|
|
||
| Defaults to 800×800. | ||
|
|
||
| ### option: Screencast.start.annotate |
Member
There was a problem hiding this comment.
why is it on screencast? there were requests to see the actions in the running browser
Contributor
Test results for "MCP"5458 passed, 340 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky38812 passed, 845 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
annotateoption torecordVideo,Video.start(), andScreencast.start()annotate.delay(default 500ms)