-
Notifications
You must be signed in to change notification settings - Fork 5.3k
feat(api): add annotate option for video and screencast #39783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,13 @@ If a screencast is already active (e.g. started by tracing or video recording), | |
|
|
||
| Defaults to 800×800. | ||
|
|
||
| ### option: Screencast.start.annotate | ||
| * since: v1.59 | ||
| - `annotate` ?<[Object]> | ||
| - `delay` ?<[int]> How long each annotation is displayed in milliseconds. Defaults to `500`. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's explain that all input actions are delayed by this amount - this came as a surprise while reading the code.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll follow up, want to add a test step there. |
||
|
|
||
| If specified, enables visual annotations on interacted elements during screencast. Interacted elements are highlighted with a semi-transparent blue box and click points are shown as red circles. | ||
|
|
||
| ## async method: Screencast.stop | ||
| * since: v1.59 | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it on screencast? there were requests to see the actions in the running browser