fix(trace-viewer): block meta refresh and sandbox snapshot iframes#40115
Merged
yury-s merged 1 commit intomicrosoft:mainfrom Apr 8, 2026
Merged
fix(trace-viewer): block meta refresh and sandbox snapshot iframes#40115yury-s merged 1 commit intomicrosoft:mainfrom
yury-s merged 1 commit intomicrosoft:mainfrom
Conversation
A crafted trace could embed a META http-equiv=refresh directive that navigated the snapshot iframe to attacker-controlled HTML served from the trace viewer origin, executing script in the trusted viewer context. Defense in depth: - Strip http-equiv=refresh and set-cookie META directives during snapshot recording (alongside the existing CSP filter). - During snapshot rendering, allow only a small whitelist of META http-equiv directives; neutralize others by renaming the http-equiv and content attributes so the browser ignores them. Protects pre-existing traces. - Sandbox the trace viewer snapshot iframes with "allow-same-origin allow-scripts" to block top navigation, popups, downloads, forms, and other capabilities that legitimate snapshots do not need.
dgozman
approved these changes
Apr 8, 2026
Contributor
Test results for "tests 1"1 failed 9 flaky39180 passed, 846 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 6441 passed, 383 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crafted trace could embed a META http-equiv=refresh directive that navigated the snapshot iframe to attacker-controlled HTML served from the trace viewer origin, executing script in the trusted viewer context.
Defense in depth: