feat(test-runner): re-use context and page when debug mode is used#9115
Merged
mxschmitt merged 6 commits intoOct 1, 2021
Merged
Conversation
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
from
8c2c109 to
8a9a6f9
Compare
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
2 times, most recently
from
f6d9131 to
7e9291f
Compare
Member
|
I think the direction is good, we just need to be a bit more careful in the implementation. |
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
from
e7dbf03 to
4a0519a
Compare
mxschmitt
commented
Sep 27, 2021
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
2 times, most recently
from
b7d8a9b to
1967701
Compare
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
from
1967701 to
ac359ee
Compare
pavelfeldman
approved these changes
Sep 30, 2021
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
from
32e95af to
9b1db46
Compare
mxschmitt
force-pushed
the
feature/re-use-page-in-debugging
branch
from
9b1db46 to
aedbe9f
Compare
sidharthv96
added a commit
to sidharthv96/playwright
that referenced
this pull request
Oct 2, 2021
…tionWithBaseChange * upstream/master: chore: roll Electron to 12.2.1 (microsoft#9271) test: use separate Playwright instance to automate inspector (microsoft#9270) feat(inspector): use chrome/msedge when chromium is not available (microsoft#9269) fix(webkit): deduce response mime type from content-type (microsoft#9264) fix(fetch): use data, form and multipart for different post data (microsoft#9248) chore: split ContextRecorder from inspector (microsoft#9250) feat: add path option to `toMatchSnapshot` (microsoft#9156) feat(cli): Support trace file URLs (microsoft#9030) browser(webkit): roll to 23/09/21 (microsoft#9107) feat(chromium): roll to r926934 (microsoft#9259) browser(chromium): roll to r926934 (microsoft#9255) test: fix 'should fulfill with fetch result and overrides' test (microsoft#9252) feat(test-runner): add reuse context mode to share a single context between tests (microsoft#9115) fix(docs): test-runner location column type (microsoft#9222)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7537