Skip to content

fix(webkit): deduce response mime type from content-type#9264

Merged
yury-s merged 2 commits into
microsoft:masterfrom
yury-s:fix-fulfill-test
Oct 1, 2021
Merged

fix(webkit): deduce response mime type from content-type#9264
yury-s merged 2 commits into
microsoft:masterfrom
yury-s:fix-fulfill-test

Conversation

@yury-s
Copy link
Copy Markdown
Member

@yury-s yury-s commented Oct 1, 2021

This fixes following test failure:

1) [webkit] › page/page-request-fulfill.spec.ts:220:1 › should fulfill with fetch result and overrides 

    page.goto: Frame load interrupted
    =========================== logs ===========================
    navigating to "http://localhost:8915/empty.html", waiting until "load"
    ============================================================

      230 |     });
      231 |   });
    > 232 |   const response = await page.goto(server.EMPTY_PAGE);
          |                               ^
      233 |   expect(response.status()).toBe(201);
      234 |   expect((await response.allHeaders()).foo).toEqual('bar');
      235 |   expect(await response.json()).toEqual({ 'foo': 'bar' });

        at /home/runner/work/playwright/playwright/tests/page/page-request-fulfill.spec.ts:232:31
        at WorkerRunner._runTestWithBeforeHooks (/home/runner/work/playwright/playwright/lib/test/workerRunner.js:466:7)
    <inner error>
    Error: Frame load interrupted
    =========================== logs ===========================
    navigating to "http://localhost:8915/empty.html", waiting until "load"
    ============================================================
        at FrameManager.frameAbortedNavigation (/home/runner/work/playwright/playwright/lib/server/frames.js:249:14)
        at FrameManager.requestFailed (/home/runner/work/playwright/playwright/lib/server/frames.js:317:12)
        at WKPage._onLoadingFailed (/home/runner/work/playwright/playwright/lib/server/webkit/wkPage.js:1290:30)
        at WKSession.<anonymous> (/home/runner/work/playwright/playwright/lib/server/webkit/wkPage.js:472:2646)
        at WKSession.emit (events.js:314:20)
        at /home/runner/work/playwright/playwright/lib/server/webkit/wkConnection.js:204:41
        at runMicrotasks (<anonymous>)
        at runNextTicks (internal/process/task_queues.js:62:5)
        at processImmediate (internal/timers.js:434:9)

Copy link
Copy Markdown
Contributor

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@yury-s yury-s merged commit 1b4adfb into microsoft:master Oct 1, 2021
@yury-s yury-s deleted the fix-fulfill-test branch October 1, 2021 20:04
sidharthv96 added a commit to sidharthv96/playwright that referenced this pull request Oct 2, 2021
…tionWithBaseChange

* upstream/master:
  chore: roll Electron to 12.2.1 (microsoft#9271)
  test: use separate Playwright instance to automate inspector (microsoft#9270)
  feat(inspector): use chrome/msedge when chromium is not available (microsoft#9269)
  fix(webkit): deduce response mime type from content-type (microsoft#9264)
  fix(fetch): use data, form and multipart for different post data (microsoft#9248)
  chore: split ContextRecorder from inspector (microsoft#9250)
  feat: add path option to `toMatchSnapshot` (microsoft#9156)
  feat(cli): Support trace file URLs (microsoft#9030)
  browser(webkit): roll to 23/09/21 (microsoft#9107)
  feat(chromium): roll to r926934 (microsoft#9259)
  browser(chromium): roll to r926934 (microsoft#9255)
  test: fix 'should fulfill with fetch result and overrides' test (microsoft#9252)
  feat(test-runner): add reuse context mode to share a single context between tests (microsoft#9115)
  fix(docs): test-runner location column type (microsoft#9222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants