Skip to content

fix(webkit): deduce response mime type from content-type #9264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yury-s merged 2 commits into from
Oct 1, 2021
Merged

fix(webkit): deduce response mime type from content-type #9264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71996af
fix(webkit): deduce response mime type from content-type
yury-s Oct 1, 2021
ac47bcc
Update test
yury-s Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/webkit/wkInterceptableRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export class WKRouteImpl implements network.RouteDelegate {
// In certain cases, protocol will return error if the request was already canceled
// or the page was closed. We should tolerate these errors.
let mimeType = response.isBase64 ? 'application/octet-stream' : 'text/plain';
const headers = headersArrayToObject(response.headers, false /* lowerCase */);
const headers = headersArrayToObject(response.headers, true /* lowerCase */);
const contentType = headers['content-type'];
if (contentType)
mimeType = contentType.split(';')[0].trim();
Expand Down
2 changes: 1 addition & 1 deletion tests/page/page-request-fulfill.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ it('should fulfill with fetch result and overrides', async ({ page, server, isEl
response,
status: 201,
headers: {
...response.headers(),
'Content-Type': 'application/json', // Case matters for the tested behavior
'foo': 'bar'
}
});
Expand Down