workaround blockly flyout variable clearing behavior #10566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jwunderl
approved these changes
May 8, 2025
thsparks
approved these changes
May 8, 2025
Contributor
thsparks
left a comment
thsparks
left a comment
There was a problem hiding this comment.
One nit, okay to ignore if you want
| const allBlocks = [block].concat(block.getChildren(false)); | ||
|
|
||
| // loop over all child variable fields | ||
| for (const block of allBlocks) { |
Contributor
There was a problem hiding this comment.
nit: could we rename this to childBlock or something, so it doesn't conflict with the block passed into the recycleBlock function?
riknoll
added a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#6181
for a detailed explanation of the behavior in blockly that necessitates this change, see RaspberryPiFoundation/blockly#9007