Dev/riknoll/different toolbox fix #10587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#6201
fixes microsoft/pxt-microbit#6206
this pr reverts #10566 and fixes the same bug in a different, equally hacky way that should be less error prone. now we skip the variable deleting logic by tricking blockly's
Block.getVarModels()function which is used when blockly tries to gather all the usages of a particular variable in the workspace.this makes it so that the variable field returns a fake variable id when in the flyout, which should be safe to do AFAIK since our flyouts never get serialized and none of the variable fields can be interacted with.