fix: filter out WSL Windows drive mount paths in conda locator (Fixes #369)#370
Merged
karthiknadig merged 2 commits intomainfrom Mar 5, 2026
Merged
fix: filter out WSL Windows drive mount paths in conda locator (Fixes #369)#370karthiknadig merged 2 commits intomainfrom
karthiknadig merged 2 commits intomainfrom
Conversation
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Linux) ➖
Legend
|
Performance Report (Windows) ✅
Legend
|
Test Coverage Report (Windows)
Coverage unchanged. |
Performance Report (macOS)
Legend
|
eleanorjboyd
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On WSL2,
~/.conda/environments.txtis shared with the Windows host and contains paths like/mnt/d/Tools/Anaconda/envs/...that point to Windows PE executables unusable from Linux. PET would try to find a conda manager for each, fail, and log ERROR for every environment — causing log spam and ~6s overhead.Changes:
is_windows_drive_mount()helper (Unix-only) to detect/mnt/<drive>/...pathsis_wsl()helper using/proc/versionWSL signature detection with result cachingget_conda_environment_paths()before expensive scanningFixes #369