This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Always generate function for QIR Interop #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because aliases are a little hard to work with during JIT, we should always generate a full function for entry point interop, even when the signature matches exactly. This will also help differentiate when we use different linkages between functions for specializations and interop.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kuzminrobin
reviewed
May 4, 2021
| @@ -1,4 +1,4 @@ | |||
| define void @Microsoft__Quantum__Testing__QIR__TestBuiltInIntrinsics__body() #0 { | |||
| define void @Microsoft__Quantum__Testing__QIR__TestBuiltInIntrinsics__body() { | |||
Contributor
There was a problem hiding this comment.
FYI
In some earlier PR I also have seen the internal keyword used.
Looks like it will not harm adding that too if appropriate.
Contributor
Author
There was a problem hiding this comment.
Exactly what I'm building towards :). You'll see that in the next PR, #1011.
kuzminrobin
approved these changes
May 4, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
FYI: I didn't look in details to .cs code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because aliases are a little hard to work with during JIT, we should always generate a full function for entry point interop, even when the signature matches exactly. This will also help differentiate when we use different linkages between functions for specializations and interop.