This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Mark all non-entrypoint functions in QIR as internal #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR should be merged after #1004, as it contains the same change in it. |
swernli
changed the title
Contributor
Author
|
This change will not build e2e until calling conventions are updated on the Runtime repo. See microsoft/qsharp-runtime#667 |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This change updates the QirGeneration rewrite step to always mark the linkage type of functions internal except when they are the generated functions for an EntryPoint (the `_Interop` variant and the message based variant). This better allows for LLVM passes to perform optimization, inling, and dead code elimination across these functions. Note that in LLVM, any global variable or function definition is considered `external` by default when no linkage is provided.
swernli
force-pushed
the
swernli/qir-internal
branch
from
3baddd8 to
3e5aca3
Compare
kuzminrobin
approved these changes
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the QirGeneration rewrite step to always mark the linkage type of functions internal except when they are the generated functions for an EntryPoint (the
_Interopvariant and the message based variant). This better allows for LLVM passes to perform optimization, inling, and dead code elimination across these functions. Note that in LLVM, any global variable or function definition is consideredexternalby default when no linkage is provided.