This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Update QIR tests for latest calling conventions #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the calling conventions used in the QIR Runtime tests to use `__Interop` wrappers for calling functions. This also required updating some older tests to the multiple entry point strategy for testing so that each test function is considered an externally callable operation/function. In addition, this updates the CMakeLists.txt to consume the bitcode files instead of the human readable .ll files wherever possible.
Contributor
|
(nit) This is the first time I hear about renaming to |
Collaborator
Author
|
@kuzminrobin This wasn't a rename so much as a switch in pattern where the expectation is that callers should use the interop functions we generate instead of trying to rely on QIR specific types. The |
kuzminrobin
reviewed
May 4, 2021
kuzminrobin
reviewed
May 4, 2021
| TestApplyIf(); | ||
| TestApplyIfWithFunctors(); | ||
| TestApplyConditionally(); | ||
| } |
kuzminrobin
approved these changes
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the calling conventions used in the QIR Runtime tests to use
__Interopwrappers for calling functions. This also required updating some older tests to the multiple entry point strategy for testing so that each test function is considered an externally callable operation/function. In addition, this updates the CMakeLists.txt to consume the bitcode files instead of the human readable .ll files wherever possible.