Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Add the internal access modifier for types, operations, and functions #345

Merged
bamarsha merged 136 commits into from
Mar 17, 2020
Merged

Add the internal access modifier for types, operations, and functions #345

bamarsha merged 136 commits into from
Mar 17, 2020

Conversation

@bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Feb 26, 2020 •
edited
Loading

Resolves #259.

TODO:

Sarah Marshall and others added 30 commits January 21, 2020 17:54
Keep track of modifiers for callables and types
f2b65d7
Make Modifiers a struct so serialization works
14e89cf
Remove runtime tests until compiler version is updated
99a5731
Add converter and update serialization test
0bbbba5
Update transformation and walker
0b02a69
Move modifiers out of the signatures
088d7c5
Fix attribute reader test
5b9a9e5
Undo superfluous changes
d0a4bd8
Update documentation for DefaultAccess
88a3e83
@bamarsha
Merge branch 'features/access-modifiers' into marshallsa/access-modif…
2bea882 
…iers
Re-enable execution tests
4ec6574
Merge branch 'marshallsa/access-modifiers' of https://github.com/micr…
77acec7 
…osoft/qsharp-compiler into marshallsa/access-modifiers
@bamarsha
Merge pull request #292 from microsoft/marshallsa/access-modifiers
122d7e8 
Add access modifiers to compiler data structures
Add parsing for access modifiers
eb43e6d
Update syntax highlighting for private and internal
0556439
Add TODOs for parsing the final syntax
c5f90db
Fix code style for creating modifiers record
32f6e9b
@bamarsha
Merge pull request #295 from microsoft/marshallsa/access-modifier-par…
cd40ab9 
…sing

Add parsing for access modifiers using alternative syntax
Parse modifiers before fragment headers
3ef2013
Include modifiers in the fragment header parser
09b5f70
Move private/internal to a separate list
16bc448
Make getFragments a normal value
56cbb57
Remove let rec from fragment parsers
c757cc4
@bamarsha
Merge branch 'features/access-modifiers' into marshallsa/access-modif…
f0ab980 
…ier-parsing-2
Move fragment header consistency check to do-block
5514bb1
Merge branch 'marshallsa/access-modifier-parsing-2' of https://github…
dbc1fe3 
….com/microsoft/qsharp-compiler into marshallsa/access-modifier-parsing-2
@bamarsha
Merge pull request #298 from microsoft/marshallsa/access-modifier-par…
e697813 
…sing-2

Update parser for access modifier syntax
Add access modifiers to code completion
4374c13
Include modifiers in code completion tests
c26c93f
optR makes more sense this way
cef7da9
Sarah Marshall and others added 18 commits March 14, 2020 21:37
Use reversible name mangling
9a74258
Add missing doc comments
293b16a
Add missing underscores
2c1c994
Remove unnecessary thunking
5e01a0a
Remove unnecessary nullability
7d5ebfa
Add test for grouping internal specializations
4b9ee1a
Refactor creating references
e7990a8
Skip test for now
5a6cd36
@bettinaheim
Pulling in changes from PR 358 (#375)
85fc5e3
Bringing over change from PR #360; avoid shadowing
a529fc5
@bamarsha
Merge pull request #370 from microsoft/marshallsa/rename-later
6861418 
Name mangling for imported internal declarations (after symbol resolution)
Re-enable multiple internal references test
9ee21d8
Update symbol table
d11d895
Group specializations by source file
7e3a656
Fix alignment
4a15dcd
Only group specializations by source if callable is internal
ec84fa1
Re-add explicit this
75e4648
@bamarsha
Merge pull request #376 from microsoft/marshallsa/many-internal-refer…
4e2675a 
…ences

Support more than one reference with the same internal name
@bamarsha bamarsha marked this pull request as ready for review March 17, 2020 03:05
bettinaheim
bettinaheim approved these changes Mar 17, 2020
View reviewed changes
@bettinaheim
Copy link
Contributor

bettinaheim commented Mar 17, 2020

Two minor comments, but other than that looks good! Well done, @MarshallSA!

@bamarsha bamarsha mentioned this pull request Mar 17, 2020
Merged
@bamarsha
Merge pull request #379 from microsoft/marshallsa/undo-editor-support…
044b7e9 
…-changes

Undo checks for current namespace in code actions/completion
@bamarsha bamarsha changed the title Add access modifiers for type, function and operation declarations Add the internal access modifier for type, function and operation declarations Mar 17, 2020
@bamarsha bamarsha changed the title Add the internal access modifier for type, function and operation declarations Add the internal access modifier for types, operations, and functions Mar 17, 2020
@bamarsha bamarsha merged commit 6a951f5 into master Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bettinaheim bettinaheim bettinaheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Access modifiers for callables and types

2 participants

@bamarsha @bettinaheim