This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Pulling in changes from PR 358#375
Merged
bettinaheim merged 3 commits intomarshallsa/rename-laterfrom Mar 16, 2020
Merged
Conversation
added 2 commits
March 16, 2020 10:47
bamarsha
added a commit
that referenced
this pull request
Mar 17, 2020
…#345) * Keep track of modifiers for callables and types * Make Modifiers a struct so serialization works * Remove runtime tests until compiler version is updated * Add converter and update serialization test * Update transformation and walker * Move modifiers out of the signatures * Fix attribute reader test * Undo superfluous changes * Update documentation for DefaultAccess * Re-enable execution tests * Add parsing for access modifiers * Update syntax highlighting for private and internal * Add TODOs for parsing the final syntax * Fix code style for creating modifiers record * Parse modifiers before fragment headers * Include modifiers in the fragment header parser * Move private/internal to a separate list * Make getFragments a normal value * Remove let rec from fragment parsers * Move fragment header consistency check to do-block * Add access modifiers to code completion * Include modifiers in code completion tests * optR makes more sense this way * Fix fragment being created without consuming input * Check for access when resolving callables * Check access when resolving types * Add error code for inaccessible type in a qualified symbol * Show specific error message for inaccessible type in open NS * Add custom error message for inaccessible callable (unqualified) - needs cleanup * Show specific error message for inaccessible qualified callables * Rename ContainsCallable/Type to TryFindCallable/Type * Make errors for using less accessible types in more accessible declarations * Reword description of Ambiguous * Update comments for NamespacesContaining{Callable, Type} * Clarify checkUdt parameter in doc comment * Update src/QsCompiler/Core/SymbolTable.fs Co-Authored-By: bettinaheim <34236215+bettinaheim@users.noreply.github.com> * NonSupportedException -> NotSupportedException * Add tests for access modifiers * Add a few more tests * Add tests for access modifiers in a referenced assembly * Update access modifiers test namespace * Skip access modifier tests for now * Add tests for type constructor accessibility * Re-enable tests except for redeclarations of references * Replace tabs with spaces * Use more descriptive names * Add access modifiers to hover information * Add access modifiers to Q# code output * Add test for skipping inaccessible items in documentation * Skip private and internal items when generating documentation * Add copyright headers * Add doc comment for new test * Clarify doc comment for WriteToStream * Hide inaccessible callables and types from code completion * Update namespace suggestion code actions for access modifiers * Add QsNullable.Bind * Refactor this if statement a little * Move nsName == null check earlier * Update doc comments for namespace suggestions * Update symbol table documentation for access modifiers * Remove the private access modifier * Move internal keyword to operations syntax group * Move "References" tests to other test groups * Allow shadowing imported internal callables * Mangle names in CompilationUnit.Build * Add TODO about reversing name mangling * Update comments about accessibility in Namespace class * Check partial NS before ref in TryAddCallableSpecialization * Skip calling FromSingleSource in NS.TryFindCallable * Allow shadowing imported internal types * Enable redeclaration test * Remove unused functions * Check source then references in TryGetAttributeDeclaredIn * Fix bug in PossibleQualifications * Fix bug in resolveInOpenNamespaces * Re-enable exception in SpecializationsDefinedInAllSources * Re-enable assertion about external specializations * Add name mangling tests * Add test for using same internal name in multiple references * No diagnostics for "conflicting" internal names * Move ResolutionResult to SymbolResolution.fs * Add comment about name tagging * Use Library2 instead of Library1Copy * Ignore async tasks instead of waiting * Disable multiple reference test * Use PascalCase in ResolutionResult module * Check if source is in references dictionary * Use reversible name mangling * Add missing doc comments * Add missing underscores * Remove unnecessary thunking * Remove unnecessary nullability * Add test for grouping internal specializations * Refactor creating references * Skip test for now * Pulling in changes from PR 358 (#375) * Bringing over change from PR #360; avoid shadowing * Re-enable multiple internal references test * Update symbol table * Group specializations by source file * Fix alignment * Only group specializations by source if callable is internal * Re-add explicit this * getting updates from master * Undo checks for current NS in code actions/completion * Check if methodDecl is null Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Bettina Heim <beheim@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.