-
Notifications
You must be signed in to change notification settings - Fork 173
Call Graph Walker #386
Call Graph Walker #386
Conversation
…T classes so they don't use positional information. This lets us safely hash these values at the transformation level.
…conventions. Fixed missing reference to namespace sub-transformation. Added DependencyType to CallGraph.
avasch01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
I had, at various different points, made logic changes to these files, but they were resolved over the course of development. When I change a file, I like to make sure there are no trailing whitespaces left in the file. Those are the remaining changes in these files, and I would like to keep them, as they should not have trailing whitespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add something that uses the call graph in this PR, or link to example of how it's intended to be used? (Sorry if I'm missing some obvious context here.) Without a concrete example it's hard for me to tell if the design is reasonable for its intended use case. Other than that it looks good.
(Edited: Oh, sorry, I see that #395 uses the call graph to find call cycles.)
bettinaheim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one thing missing is the override for partial applications I believe. Please add that before merging. Other than that, lgtm.
Adding the basics of the call graph walker.