This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Cycle Tests #395
Merged
Cycle Tests #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ScottCarda-MS
changed the base branch from
sccarda/CallGraphWalker
to
features/CallGraphWalker
…on under CallGraphTests.fs.
bamarsha
approved these changes
Apr 17, 2020
cesarzc
reviewed
Apr 17, 2020
cesarzc
reviewed
Apr 17, 2020
cesarzc
approved these changes
Apr 17, 2020
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Looks good to me. I just made a few minor suggestions.
Contributor
Author
|
I am going to short-circuit the discussions surrounding the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests an algorithm for finding cycles in call graph. The current algorithm in this PR does not meet the requirements, and a more complete algorithm will need to replace it in the future.