This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Reference loading performance accounting breakdown. (#590) #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor code a bit to be able to make performance tracking more widely available. * Better perfomance tracking methods. * It works, clean-up pending. * Clean-up before publishing PR. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Log error when somwthing goes wrong while tracking performance. * Made two source files nullable enabled. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Contributor
Author
|
This changes have already been reviewed in PR #590. This new PR is created because the feature branch in which the previous PR was merged ( This PR cherry-picks the commit from |
bamarsha
approved these changes
Sep 22, 2020
Contributor
bamarsha
left a comment
bamarsha
left a comment
There was a problem hiding this comment.
This new PR is created because the feature branch in which the previous PR was merged (feature/perf-tracking-additions) was based on master and after its rename to main, it can no longer be seamlessly updated.
This surprises me, because renaming a branch shouldn't affect merges in Git.
cesarzc
added a commit
that referenced
this pull request
Dec 10, 2020
* Reference loading performance accounting breakdown. (#590) (#630) * Refactor code a bit to be able to make performance tracking more widely available. * Better perfomance tracking methods. * It works, clean-up pending. * Clean-up before publishing PR. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Log error when somwthing goes wrong while tracking performance. * Made two source files nullable enabled. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Added performance tracking for specific rewrite steps based off the name field of the step. * Use a separate Task enum value for specific rewrite steps. * Made description more consistent. * Moved start of rewrite steps task. Removed whitespace from details. * Make sure a suffix can only be added to leaf tasks. * PR comments * Fixed build issues that arised from merging 'main' into 'feature/performance-tracking-improvements'. * Add performance tracking tests (#713) * Expanded compilation tracker interface. * Added performance tracking tests. * Fixed project file. * Created CompilationTrackerTests.fs source file. * Added a few more test cases in F#. * Added more test cases to validate time accounting. * Added expcetion-based test cases. * Removed Tests.PerformanceTracking C# project. * Use built-in Assert.Throws. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Format type annotations. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Remove pragma directive that is no longer needed. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Scott Carda <sccarda@microsoft.com> Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code a bit to be able to make performance tracking more widely available.
Better perfomance tracking methods.
Apply suggestions from code review
Co-authored-by: Sarah Marshall 33814365+samarsha@users.noreply.github.com
Log error when something goes wrong while tracking performance.
Made two source files nullable enabled.
Co-authored-by: Sarah Marshall 33814365+samarsha@users.noreply.github.com