This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 173
Integrate 'feature/performance-tracking-improvements' to 'main' #728
Merged
cesarzc
merged 21 commits into
main
from
cesarzc/merge-feature-performance-tracking-improvements-to-main
Dec 10, 2020
Merged
Integrate 'feature/performance-tracking-improvements' to 'main' #728
cesarzc
merged 21 commits into
main
from
cesarzc/merge-feature-performance-tracking-improvements-to-main
Dec 10, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor code a bit to be able to make performance tracking more widely available. * Better perfomance tracking methods. * It works, clean-up pending. * Clean-up before publishing PR. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Log error when somwthing goes wrong while tracking performance. * Made two source files nullable enabled. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
…ame field of the step.
Tracking for Specific Rewrite Steps
…ormance-tracking-improvements'.
…mance-tracking-improvements-201023 Merge 'main' to 'feature/performance-tracking-improvements'
* Expanded compilation tracker interface. * Added performance tracking tests. * Fixed project file. * Created CompilationTrackerTests.fs source file. * Added a few more test cases in F#. * Added more test cases to validate time accounting. * Added expcetion-based test cases. * Removed Tests.PerformanceTracking C# project. * Use built-in Assert.Throws. * Apply suggestions from code review Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> * Format type annotations. Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
…eature-performance-tracking-improvements-to-main'.
…mprovements-to-main
…mprovements-to-main
…mprovements-to-main
…mprovements-to-main
…mprovements-to-main
…mprovements-to-main
ScottCarda-MS
approved these changes
Dec 9, 2020
Contributor
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change integrates the changes in the
feature/performance-tracking-improvementsbranch tomain.